curtin

Merge ~mwhudson/curtin:update_nvram-default into curtin:master

  1. Git
  2. lp:~mwhudson/curtin
  3. update_nvram-default
  4. Merge into master
Proposed by Michael Hudson-Doyle
Status: Merged
Approved by: Chad Smith
Approved revision: 59d005a7dbdd0366388aafc3bc26e2ea1f90dee8
Merge reported by: Server Team CI bot
Merged at revision: not available
Proposed branch: ~mwhudson/curtin:update_nvram-default
Merge into: curtin:master
Diff against target: 13 lines (+1/-1)
1 file modified
curtin/commands/install_grub.py (+1/-1)
Reviewer Review Type Date Requested Status
Chad Smith Approve
Server Team CI bot continuous-integration Approve
Review via email: mp+389936@code.launchpad.net

Commit message

restore default of grub.update_nvram to True in install_grub

This was accidentally changed when the grub installation code was
converted from shell to Python.

To post a comment you must log in.
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:59d005a7dbdd0366388aafc3bc26e2ea1f90dee8
https://jenkins.ubuntu.com/server/job/curtin-ci/176/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/176/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/176/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/176/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/176/

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/176//rebuild

review: Approve (continuous-integration)
Revision history for this message
Chad Smith (chad.smith) wrote :

LGTM, it was an omission as well on a previous MP touching this and the documentation. https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382931/

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/curtin/commands/install_grub.py b/curtin/commands/install_grub.py
2index 777aa35..5f8311f 100644
3--- a/curtin/commands/install_grub.py
4+++ b/curtin/commands/install_grub.py
5@@ -346,7 +346,7 @@ def install_grub(devices, target, uefi=None, grubcfg=None):
6
7 LOG.debug("installing grub to target=%s devices=%s [replace_defaults=%s]",
8 target, devices, grubcfg.get('replace_default'))
9- update_nvram = config.value_as_boolean(grubcfg.get('update_nvram', False))
10+ update_nvram = config.value_as_boolean(grubcfg.get('update_nvram', True))
11 distroinfo = distro.get_distroinfo(target=target)
12 target_arch = distro.get_architecture(target=target)
13 rhel_ver = (distro.rpm_get_dist_id(target)

Subscribers

People subscribed via source and target branches