Merge lp:~mwaddel/linaro-image-tools/vexpress-additions-v3 into lp:linaro-image-tools/11.11

Proposed by Matt Waddel
Status: Merged
Merged at revision: 30
Proposed branch: lp:~mwaddel/linaro-image-tools/vexpress-additions-v3
Merge into: lp:linaro-image-tools/11.11
Diff against target: 100 lines (+43/-19)
1 file modified
linaro-media-create (+43/-19)
To merge this branch: bzr merge lp:~mwaddel/linaro-image-tools/vexpress-additions-v3
Reviewer Review Type Date Requested Status
Loïc Minier (community) Needs Fixing
Review via email: mp+33446@code.launchpad.net

Description of the change

1) Refactored boot/rootfs creation for adding new platforms.
2) Added the Versatile Express platform.

To post a comment you must log in.
Revision history for this message
Loïc Minier (lool) wrote :

Matt, overall it looked good, there is only one small issue in r31, you have a reference to omap in the vexpress case statement:
    sudo cp -f ${DIR}/binary/${parts_dir}/uInitrd.omap ${DIR}/disk/uInitrd

feel free to fix this in an additional commit on top

You didn't mention whether you tested that, did you manage to create a working image with this?

Thanks!

review: Needs Fixing
Revision history for this message
Matt Waddel (mwaddel) wrote :

The current vexpress doesn't use the uInitrd. So this is a benign problem and doesn't affect the booting vexpress image. I'll fix it when we get a specific uInitrd.vexpress file (if that's ok with you).

Revision history for this message
Loïc Minier (lool) wrote :

Well you should fix it before I merge since we caught that issue in review, but you can comment out this line locally until there's an uInitrd in the daily builds

Revision history for this message
Matt Waddel (mwaddel) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'linaro-media-create'
--- linaro-media-create 2010-08-05 15:10:31 +0000
+++ linaro-media-create 2010-08-23 20:22:38 +0000
@@ -169,7 +169,7 @@
169 echo ""169 echo ""
170170
171 echo ""171 echo ""
172 echo "Installing OMAP Boot Loader"172 echo "Installing Boot Loader"
173 echo ""173 echo ""
174174
175 if [ "$IS_LIVE" ]; then175 if [ "$IS_LIVE" ]; then
@@ -180,19 +180,36 @@
180180
181 mkdir -p ${DIR}/disk || true181 mkdir -p ${DIR}/disk || true
182 sudo mount ${MMC1} ${DIR}/disk182 sudo mount ${MMC1} ${DIR}/disk
183 if test -e binary/${parts_dir}/${MLO_FILE} -a -e binary/${parts_dir}/${UBOOT_FILE}; then183 case "$DEVIMAGE" in
184 sudo cp -v binary/${parts_dir}/${MLO_FILE} ${DIR}/disk/MLO184 beagle)
185 sudo cp -v binary/${parts_dir}/${UBOOT_FILE} ${DIR}/disk/u-boot.bin185 if test -e binary/${parts_dir}/${MLO_FILE} -a -e binary/${parts_dir}/${UBOOT_FILE}; then
186 fi186 sudo cp -v binary/${parts_dir}/${MLO_FILE} ${DIR}/disk/MLO
187 sync187 sudo cp -v binary/${parts_dir}/${UBOOT_FILE} ${DIR}/disk/u-boot.bin
188 cd ${DIR}188 fi
189 echo "done"189 sync
190190 cd ${DIR}
191 sudo cp -f ${DIR}/binary/${parts_dir}/uImage.omap ${DIR}/disk/uImage191 echo "done"
192 sudo cp -f ${DIR}/binary/${parts_dir}/uInitrd.omap ${DIR}/disk/uInitrd192
193193 sudo cp -f ${DIR}/binary/${parts_dir}/uImage.omap ${DIR}/disk/uImage
194 sudo mkimage -A arm -O linux -T script -C none -a 0 -e 0 -n "$CODENAME 10.05" -d ${DIR}/binary/boot.cmd ${DIR}/disk/boot.scr194 sudo cp -f ${DIR}/binary/${parts_dir}/uInitrd.omap ${DIR}/disk/uInitrd
195 sudo cp -v ${DIR}/disk/boot.scr ${DIR}/disk/boot.ini195
196 sudo mkimage -A arm -O linux -T script -C none -a 0 -e 0 -n "$CODENAME 10.05" -d ${DIR}/binary/boot.cmd ${DIR}/disk/boot.scr
197 sudo cp -v ${DIR}/disk/boot.scr ${DIR}/disk/boot.ini
198 ;;
199 vexpress)
200 sudo cp -v ${DIR}/binary/${parts_dir}/u-boot-ca9x4_ct_vxp.bin \
201 ${DIR}/disk/ubootca9.bin
202 sudo cp -f ${DIR}/binary/${parts_dir}/vmlinuz*-vexpress ${DIR}/disk/vmlinuz
203 mkimage -A arm -O linux -T kernel -C none -a 0x60008000 -e 0x60008000 \
204 -n "Linux" -d ${DIR}/disk/vmlinuz ${DIR}/disk/uImage.vxp
205 sudo cp -f ${DIR}/binary/${parts_dir}/uInitrd.omap ${DIR}/disk/uInitrd
206 ;;
207 *)
208 echo "Set --dev parameter: --dev <beagle|vexpress>" 1>&2
209 cleanup_workdir
210 exit
211 ;;
212 esac
196213
197 echo "#!/bin/sh" > /tmp/rebuild_uinitrd.sh214 echo "#!/bin/sh" > /tmp/rebuild_uinitrd.sh
198 echo "" >> /tmp/rebuild_uinitrd.sh215 echo "" >> /tmp/rebuild_uinitrd.sh
@@ -362,6 +379,12 @@
362--image_file <xxx>379--image_file <xxx>
363 specify name of image file380 specify name of image file
364381
382--dev <board>
383 use development boot options; this includes setting up serial ttys as well
384 as enabling normal debug options for the target board. Current board values:
385 * beagle
386 * vexpress
387
365Additional/Optional options:388Additional/Optional options:
366-h --help389-h --help
367 this help390 this help
@@ -390,11 +413,6 @@
390 Create boot command for casper/live images; adds only-ubiquity option413 Create boot command for casper/live images; adds only-ubiquity option
391 to allow use of live installer on boards with 256M memory - like beagle414 to allow use of live installer on boards with 256M memory - like beagle
392415
393--dev <board>
394 use development boot options; this includes setting up serial ttys as well
395 as enabling normal debug options for the target board. Current board values:
396 * beagle
397
398--console <ttyXY>416--console <ttyXY>
399 add a console to kernel boot parameter; this parameter can be defined417 add a console to kernel boot parameter; this parameter can be defined
400 multiple times.418 multiple times.
@@ -508,6 +526,12 @@
508 serial_opts="$serial_opts serialtty=ttyS2"526 serial_opts="$serial_opts serialtty=ttyS2"
509 fi527 fi
510 ;;528 ;;
529 vexpress)
530 serial_opts="$serial_opts console=tty0 console=ttyAMA0,38400n8"
531 if [ "$IS_LIVE" ]; then
532 serial_opts="$serial_opts serialtty=ttyAMA0"
533 fi
534 ;;
511 *)535 *)
512 echo "unknown --dev paramater: $DEVIMAGE" 1>&2536 echo "unknown --dev paramater: $DEVIMAGE" 1>&2
513 ;;537 ;;

Subscribers

People subscribed via source and target branches