Code review comment for lp:~mwaddel/linaro-image-tools/vexpress-additions-v3

Revision history for this message
Loïc Minier (lool) wrote :

Matt, overall it looked good, there is only one small issue in r31, you have a reference to omap in the vexpress case statement:
    sudo cp -f ${DIR}/binary/${parts_dir}/uInitrd.omap ${DIR}/disk/uInitrd

feel free to fix this in an additional commit on top

You didn't mention whether you tested that, did you manage to create a working image with this?

Thanks!

review: Needs Fixing

« Back to merge proposal