Merge ~mvoelker/cloud-init:id_vmware_openstack into cloud-init:master
Proposed by
Mark T. Voelker
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Ryan Harper | ||||
Approved revision: | a79dc3374ab7681f344f2a74762b7924830df09f | ||||
Merge reported by: | Server Team CI bot | ||||
Merged at revision: | not available | ||||
Proposed branch: | ~mvoelker/cloud-init:id_vmware_openstack | ||||
Merge into: | cloud-init:master | ||||
Diff against target: |
57 lines (+28/-0) 2 files modified
tests/unittests/test_ds_identify.py (+20/-0) tools/ds-identify (+8/-0) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Server Team CI bot | continuous-integration | Approve | |
Ryan Harper | Needs Fixing | ||
Review via email: mp+367129@code.launchpad.net |
Commit message
Allow identification of OpenStack by Asset Tag
When OpenStack is deployed on some hypervisors (such as VMware
vSphere), cloud-init doesn't detect that it needs to probe the
metadata service because the DMI product name field can't be set
to a field that is recognized by cloud-init. However, the asset
tag field can be set via flavor extra specs or image metadata.
A similar approach is already used to identify Open Telekom Cloud.
This patch allows cloud init to recognize "OpenStack Nova" or
"OpenStack Compute" in the asset tag field as an indication that
the instance being configured is running on an OpenStack platform.
LP: #1669875
To post a comment you must log in.
Thanks for putting up a patch for this.
I've added a comment below and I'd like to have you
add the following unittests for this change to your branch.
http:// paste.ubuntu. com/p/ybhFdggWZ Y/