lp:~mvo/snapd/+git/snapd-mvo

Owned by Michael Vogt
Get this repository:
git clone https://git.launchpad.net/~mvo/snapd/+git/snapd-mvo

Import details

Import Status: Reviewed

This repository is an import of the Git repository at https://github.com/mvo5/snappy.

The next import is scheduled to run in 34 minutes.

Last successful import was 5 hours ago.

Import started 5 hours ago on alnitak and finished 5 hours ago taking 1 minute — see the log
Import started 11 hours ago on izar and finished 11 hours ago taking 1 minute — see the log
Import started 17 hours ago on alnitak and finished 17 hours ago taking 1 minute — see the log
Import started 23 hours ago on izar and finished 23 hours ago taking 1 minute — see the log
Import started on 2019-02-17 on izar and finished on 2019-02-17 taking 1 minute — see the log
Import started on 2019-02-17 on alnitak and finished on 2019-02-17 taking 1 minute — see the log
Import started on 2019-02-16 on izar and finished on 2019-02-16 taking 1 minute — see the log
Import started on 2019-02-16 on alnitak and finished on 2019-02-16 taking 50 seconds — see the log
Import started on 2019-02-16 on izar and finished on 2019-02-16 taking 50 seconds — see the log
Import started on 2019-02-16 on izar and finished on 2019-02-16 taking 1 minute — see the log

Branches

Name Last Modified Last Commit
active-task-times 2019-02-18 09:18:51 UTC 7 hours ago
Merge remote-tracking branch 'upstream/master' into active-task-times

Author: Michael Vogt
Author Date: 2019-02-18 09:18:51 UTC

Merge remote-tracking branch 'upstream/master' into active-task-times

unbreak-trusty 2019-02-17 17:08:46 UTC 23 hours ago
tests: disable trusty-proposed for now

Author: Michael Vogt
Author Date: 2019-02-17 17:08:34 UTC

tests: disable trusty-proposed for now

We need to disable trusty-proposed because there is an inconsistency
in the trusty-proposed archive that leads to the following error:
$ sudo apt install inux-generic-lts-xenial
inux-generic-lts-xenial : Depends: linux-image-generic-lts-xenial (= 4.4.0.143.124) but 4.4.0.141.121 is to be installed

fix-upgrade-test 2019-02-15 17:58:29 UTC 2019-02-15
tests: fix upgrade-from-2.15 with kernel 4.15

Author: Michael Vogt
Author Date: 2019-02-15 15:09:19 UTC

tests: fix upgrade-from-2.15 with kernel 4.15

snapd version 2.15 will not work with kernels newer than
4.4 because later kernels require snap-exec to be mmapable.
This PR adds the missing rule manually.

debhelper-oh-please 2019-02-14 18:12:14 UTC 2019-02-14
Merge remote-tracking branch 'upstream/master' into debhelper-oh-please

Author: Michael Vogt
Author Date: 2019-02-14 18:12:14 UTC

Merge remote-tracking branch 'upstream/master' into debhelper-oh-please

disable-names 2019-02-14 17:09:15 UTC 2019-02-14
tests: stop catalog-update/apt-hooks test for now

Author: Michael Vogt
Author Date: 2019-02-14 15:25:45 UTC

tests: stop catalog-update/apt-hooks test for now

The store is unhappy currently and won't answer to requests for
names. So this test always fails. Once the store is happy again
we can re-enable this test.

ims-interface 2019-02-13 13:55:55 UTC 2019-02-13
interfaces: add url of kernel intel MEI documentation to intel-mei interface

Author: Michael Vogt
Author Date: 2019-02-13 13:55:55 UTC

interfaces: add url of kernel intel MEI documentation to intel-mei interface

ensure-snapd-transition 2019-02-13 13:50:06 UTC 2019-02-13
Merge remote-tracking branch 'upstream/master' into ensure-snapd-transition

Author: Michael Vogt
Author Date: 2019-02-13 13:50:06 UTC

Merge remote-tracking branch 'upstream/master' into ensure-snapd-transition

fix-snapd-snap-restart-handling 2019-02-13 08:58:53 UTC 2019-02-13
snapstate: address review feedback

Author: Michael Vogt
Author Date: 2019-02-13 08:58:53 UTC

snapstate: address review feedback

active-task-time 2019-02-13 08:44:22 UTC 2019-02-13
many: collect time each task runs and display with `snap change <id>`

Author: Michael Vogt
Author Date: 2019-02-13 08:44:22 UTC

many: collect time each task runs and display with `snap change <id>`

This PR imports the changes from Maciej that measures how much time
each task taskes to run. This data is stored in the state and can
be displayed via `snap change <id>`. E.g.:
```
$ snap change 563
Status Spawn Ready Active Summary
Done today at 09:28 CET today at 09:29 CET 13ms Stop snap "test-snapd-tools" (6) services
Done today at 09:28 CET today at 09:29 CET 39ms Remove aliases for snap "test-snapd-tools"
Done today at 09:28 CET today at 09:29 CET 27ms Make snap "test-snapd-tools" (6) unavailable to the system
Done today at 09:28 CET today at 09:29 CET 10ms Remove security profiles of snap "test-snapd-tools"
```
This is a first (baby) step towards measuring where we spend time
in e.g. firstboot seeding and where we need to optimize.

Thanks to Maciej Borzecki and Zygmunt Krynicki which wrote most of
this code.

help_url2 2019-02-12 12:19:49 UTC 2019-02-12
tests/main/xdg-open-compat: fix the test to do as advertised

Author: Maciej Borzecki
Author Date: 2019-01-30 14:53:19 UTC

tests/main/xdg-open-compat: fix the test to do as advertised

The xdg-open-compat test has been broken since the core snap started shipping
xdg-open that actually talks to io.snaocraft.Launcher via `snapctl user-open`.
Because of this, the actual com.canonical.SafeLauncher interface was never
accessed, and the test ended up just redoing what xdg-open test does.

Attempt to fix the test by calling com.canonical.SafeLauncher diirectly via
dbus-send.

Also, snapd-xdg-open does not allow help: scheme, make sure that we account for
that in the test.

Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>

improve-generator-test 2019-02-11 16:17:13 UTC 2019-02-11
tests: improve snaps-system-env test

Author: Michael Vogt
Author Date: 2019-02-11 16:11:32 UTC

tests: improve snaps-system-env test

In 18.04 we had a regression when we installed the snapd systemd
environment generator. Installing it caused LP: #1814355 and
the PATH for systemd services looked suddently like:
```
   /sbin:/usr/sbin:/bin:/usr/bin:/snap/bin
```
instead of the expected:
```
   /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin
```

A better test that checked the *full* expected PATH instead of just
the addition of :/snap/bin would have caught this regression.

This PR adds the test for the full PATH now.

remodel-v0 2019-02-11 15:11:49 UTC 2019-02-11
devicestate: ensure sequential install of required snaps

Author: Michael Vogt
Author Date: 2019-02-11 15:11:49 UTC

devicestate: ensure sequential install of required snaps

master 2019-02-08 15:17:42 UTC 2019-02-08
Merge pull request #6484 from mvo5/rm-aa-profile-snap-cofine-harder

Author: Michael Vogt
Author Date: 2019-02-08 15:17:42 UTC

Merge pull request #6484 from mvo5/rm-aa-profile-snap-cofine-harder

debian: ensure leftover usr.lib.snapd.snap-confine is gone

rm-aa-profile-snap-cofine-harder 2019-02-08 09:48:30 UTC 2019-02-08
debian: ensure leftover usr.lib.snapd.snap-confine is gone

Author: Michael Vogt
Author Date: 2019-02-08 09:41:22 UTC

debian: ensure leftover usr.lib.snapd.snap-confine is gone

In commit 0dce4704a5d (2017-03-28, snapd v2.23.6) we renamed
/etc/apparmor.d/usr.lib.snap-confine to usr.lib.snap-confine.real
to fix LP: #1673247 - however some people (upgrades?) still have
the old usr.lib.snap-confine file. This seems to be loaded instead
of the correct usr.lib.snap-confine.real profile. To fix this we
use the rather blunt approach to remove the file forcefully if
it is unchanged.

import-debian-salsa-zyga 2019-02-08 08:09:57 UTC 2019-02-08
releasing package snapd version 2.37.2-1

Author: Michael Hudson-Doyle
Author Date: 2019-02-07 08:36:00 UTC

releasing package snapd version 2.37.2-1

core-core16 2019-02-07 16:49:13 UTC 2019-02-07
image: support core as an "alias" for core16

Author: Michael Vogt
Author Date: 2019-02-07 16:46:03 UTC

image: support core as an "alias" for core16

smoke-more 2019-02-07 15:38:56 UTC 2019-02-07
Merge remote-tracking branch 'upstream/master' into smoke-more

Author: Michael Vogt
Author Date: 2019-02-07 15:38:56 UTC

Merge remote-tracking branch 'upstream/master' into smoke-more

release-2.37.2 2019-02-06 09:28:07 UTC 2019-02-06
Merge remote-tracking branch 'upstream/master' into release-2.37.2

Author: Michael Vogt
Author Date: 2019-02-06 09:28:07 UTC

Merge remote-tracking branch 'upstream/master' into release-2.37.2

allow-non-classic-with-classic-2.37 2019-02-06 08:05:11 UTC 2019-02-06
cmd_snap_op: do not use esc.bold (not available yet in 2.37)

Author: Michael Vogt
Author Date: 2019-02-06 08:05:11 UTC

cmd_snap_op: do not use esc.bold (not available yet in 2.37)

fix-wal-e-harder 2019-02-05 11:54:40 UTC 2019-02-05
snap-confine: remove special handling of /var/lib/jenkins

Author: Michael Vogt
Author Date: 2019-02-04 16:14:50 UTC

snap-confine: remove special handling of /var/lib/jenkins

We added special handling of the jenkins user in dd3c2f4 in
snap-confine by optionally mounting /var/lib/jenkins into the
core snap. However this is only needed to make *confined* snaps
work for the jenkins user which *never* worked.

When trying to run a confined snap (like test-snapd-tools) as
the jenkins user with an older versions of snapd we get the
following message:
```
cannot create user data directory: /var/lib/jenkins/snap/test-snapd-tools/6: Read-only file system
```

So this PR reverts the special handling of jenkins in snap-confine
becuase:
a) its a very special case for something that did not work before
b) it breaks existing users, I got a (private) bugreport that
   people get:
   `cannot perform operation: mount --rbind /var/lib/jenkins`

Note that this does *not* affect classic snaps which keep working
with this change for the special users that have homes in /var/lib.

fix-wal-e-2.37 2019-02-05 07:55:53 UTC 2019-02-05
snap-confine: fix classic snaps for users with /var/lib/* homedirs (#6471)

Author: Michael Vogt
Author Date: 2019-02-05 07:51:52 UTC

snap-confine: fix classic snaps for users with /var/lib/* homedirs (#6471)

When we removed the quirks system in commit [1da9316](https://github.com/snapcore/snapd/commit/1da9316e717d119852b827becb5a17b33713d032) we removed the following apparmor rule as well:

```
     /var/lib/** rw,
```
The unintended side-effect of this change is that we broke snaps
for users with homedirs in /var/lib/ like "postgresql", "jenkins"
and potentially more. They now get the error:

```
cannot create user data directory: /var/lib/postgresql/snap/wal-e/13: Permission denied
```
We added a special case for jenkins which unfortunately is not
enough. This PR makes the snap-confine rule more general which
will unbreak all classic snaps that use /var/lib/* as their
homedir. This will fix the wal-e snap which is classic and needs
to run as the postgresql user to perform its tasks.

We probably still need a followup that deals with confined snaps
like jenkins in a more general manner like the current targeted
jenkins fix.

fix-wal-e 2019-02-04 17:23:33 UTC 2019-02-04
further review feedback

Author: Samuele Pedroni
Author Date: 2019-02-04 17:23:33 UTC

further review feedback

systemd-env-gen-lp1814355 2019-02-04 08:26:30 UTC 2019-02-04
tests/main/snap-system-env: account for /snap/bin missing from PATH in 18.04

Author: Maciej Borzecki
Author Date: 2019-02-04 08:06:45 UTC

tests/main/snap-system-env: account for /snap/bin missing from PATH in 18.04

Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>

measures-cmd 2019-02-01 14:55:37 UTC 2019-02-01
measure: add missing lock *cough*

Author: Michael Vogt
Author Date: 2019-02-01 14:55:37 UTC

measure: add missing lock *cough*

snap-measures-cmd 2019-02-01 09:46:23 UTC 2019-02-01
many: add simple performance measure tool mostly for firstboot

Author: Michael Vogt
Author Date: 2019-01-17 08:31:24 UTC

many: add simple performance measure tool mostly for firstboot

This PR adds a very simplisit "measure" module to the tree that
can be used to take measurements of things that take time.

The API is minimal, the intended use (for now) is:
```
func foo() {
   m := measure.New("things happening in foo")
   defer m.Done()
   ...
}
```
The PR adds some measures into the firstboot code but we need to
experiment a bit too see where else we need to measure.

With that there is a new `snap debug measures` command that can
be used to get the most recent measurements.

locking-longer 2019-01-31 12:33:33 UTC 2019-01-31
locking.c: run indent

Author: Michael Vogt
Author Date: 2019-01-31 12:33:33 UTC

locking.c: run indent

locking-2 2019-01-31 12:29:49 UTC 2019-01-31
snap-confine: fix incorrect "sanity timeout 3s" message

Author: Michael Vogt
Author Date: 2019-01-31 12:17:03 UTC

snap-confine: fix incorrect "sanity timeout 3s" message

The code has a log message that says that the timeout is
initialized to 3 seconds. However the code actually uses
6 seconds. This "refactors" things so that timeout and
message stay in sync.

sigalarm 2019-01-31 12:07:32 UTC 2019-01-31
snap-confine: provide proper error message on sc_sanity_timeout

Author: Michael Vogt
Author Date: 2019-01-31 12:07:28 UTC

snap-confine: provide proper error message on sc_sanity_timeout

The code that communicates with the helper process does setup
a "sanity" timeout currently. If that timeout is reached then
snap-confine dies. Unfortunately the error message is misleading
and says "interrupted system call" which does not help finding
the underlying issue.

This PR changes the code so that the timeout is checked before
the read error is printed. This will lead to the slightly better:
```
error: sanity timeout expired
```
which is still not great but it helps to see that this is not
an error in the code but something with the interaction of
snap-confine and its helpers.

perf-count 2019-01-31 11:59:54 UTC 2019-01-31
many: add simple performance logging mostly for firstboot

Author: Michael Vogt
Author Date: 2019-01-17 08:31:24 UTC

many: add simple performance logging mostly for firstboot

trivial-err-drive-by 2019-01-31 08:51:22 UTC 2019-01-31
address review feedback

Author: Michael Vogt
Author Date: 2019-01-31 08:51:22 UTC

address review feedback

parallel-instances-fix-hooks-discovery-2.37 2019-01-31 08:48:38 UTC 2019-01-31
overlord/hookstate: shuffle the test code around

Author: Maciej Borzecki
Author Date: 2019-01-30 13:15:49 UTC

overlord/hookstate: shuffle the test code around

Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>

tests-fix-logs-daemon-notify-2.37 2019-01-31 08:45:54 UTC 2019-01-31
Improve check with connected interface

Author: Sergio Cazzolato
Author Date: 2019-01-25 15:34:20 UTC

Improve check with connected interface

arm-illegal 2019-01-30 08:44:41 UTC 2019-01-30
tests: update smoke/sandbox test for armhf

Author: Michael Vogt
Author Date: 2019-01-30 08:44:37 UTC

tests: update smoke/sandbox test for armhf

While running the beta validation on the armhf I noticed that the
behaviour of illegal syscalls is different from the other arches
we have. Most arches just give ENOSYS in errno. However on armhf
the process is killed with SIGILL.

This PR updates the test to account for that.

release-2.37.1 2019-01-29 21:24:59 UTC 2019-01-29
Merge remote-tracking branch 'upstream/master' into release-2.37.1

Author: Michael Vogt
Author Date: 2019-01-29 21:24:59 UTC

Merge remote-tracking branch 'upstream/master' into release-2.37.1

feature/home-for-jenkins-just-fix 2019-01-29 13:54:54 UTC 2019-01-29
cmd/snap-confine: add special case for Jenkins

Author: Zygmunt Krynicki
Author Date: 2019-01-29 10:32:48 UTC

cmd/snap-confine: add special case for Jenkins

The 2.37 release has dropped the "quirk" system responsible for the
special layout of /var/lib. The /var/lib directory was a tmpfs, with
empty directories and bind mount re-creating the original contents of
/var/lib from the base snap. This feature made it possible to mkdir
/var/lib/lxd, which was *not* present in the core snap, and bind mount
it to /var/lib/lxd from the host.

This used to be a part of a backwards compatibility fix for the time
when LXD was installed as a classic package on the host. LXD has since
moved over to a snap and that directory lost any relevance, culminating
with the removal of the quirk system in the 2.37 development cycle.

The removal of the quirk system also removed permissions that
snap-confine used to have, that gave it wide access to /var/lib.
The Jenkins system is often packaged using classic packages. The classic
package adds a "jenkins" user and sets its home directory to
/var/lib/jenkins. A system using Jenkins CI that internally uses snap
commands would invoke snap applications from the context of that user.

This brings us to the problem: snapd doesn't fully support users with
their home directories outside of /home. Due to complexity of the mount
namespace handling and the apparmor based sandbox with path-based
permissions, adding support for arbitrary home directories is
challenging. It was also untested in the snapd CI system.

In 2.36 and earlier, using snaps from the Jenkins user and its home
directory of /var/lib/jenkins only worked by accident, because the quirk
system granted relevant permissions to snap-confine, enabling it to
create $SNAP_USER_DATA directories. With the release of 2.37 we started
observing users reporting that their Jenkins CI systems can no longer
use snap applications.

While support for arbitrary home directories is desirable, it it needs
much more code to enable properly. An isolated special-case for Jenkins
is manageable and allows us to buy more time to explore proper support
for more cases in subsequent releases.

Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>

fix-x-builddeb-harder 2019-01-29 11:53:07 UTC 2019-01-29
snapcraft.yaml: fix XBuildDeb PATH for go-1.10

Author: Michael Vogt
Author Date: 2019-01-29 11:53:07 UTC

snapcraft.yaml: fix XBuildDeb PATH for go-1.10

With the change to golang-1.10 the go binary is no longer in the
PATH. Some tools (like get-deps.sh) need it though. This PR
ensures the PATH is set correctly early enough so that get-deps.sh
can find the "go" binary.

revert-quirks-removal-gh6123-master 2019-01-29 09:45:05 UTC 2019-01-29
Revert "cmd/snap-confine,snap-update-ns: discard quirks"

Author: Michael Vogt
Author Date: 2019-01-29 09:45:05 UTC

Revert "cmd/snap-confine,snap-update-ns: discard quirks"

This reverts commit 1da9316e717d119852b827becb5a17b33713d032.

revert-quirks-removal-gh6123 2019-01-29 09:40:02 UTC 2019-01-29
Revert "cmd/snap-confine,snap-update-ns: discard quirks"

Author: Michael Vogt
Author Date: 2019-01-29 09:40:02 UTC

Revert "cmd/snap-confine,snap-update-ns: discard quirks"

This reverts commit 1da9316e717d119852b827becb5a17b33713d032.

fix-debian-9-2.37 2019-01-29 06:20:15 UTC 2019-01-29
tests/lib/prepare-restore: make the Go workaround Debian 9 specific

Author: Maciej Borzecki
Author Date: 2019-01-28 15:41:46 UTC

tests/lib/prepare-restore: make the Go workaround Debian 9 specific

Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>

reexec-from-snapd-fix 2019-01-29 06:05:08 UTC 2019-01-29
Merge remote-tracking branch 'upstream/master' into reexec-from-snapd-fix

Author: Michael Vogt
Author Date: 2019-01-29 06:05:08 UTC

Merge remote-tracking branch 'upstream/master' into reexec-from-snapd-fix

fix-debian-9 2019-01-28 15:41:46 UTC 2019-01-28
tests/lib/prepare-restore: make the Go workaround Debian 9 specific

Author: Maciej Borzecki
Author Date: 2019-01-28 15:41:46 UTC

tests/lib/prepare-restore: make the Go workaround Debian 9 specific

Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>

fix-snapcraft-build-in-lp 2019-01-25 13:43:49 UTC 2019-01-25
snapcraft.yaml: fix snapcraft building in launchpad

Author: Michael Vogt
Author Date: 2019-01-25 13:43:49 UTC

snapcraft.yaml: fix snapcraft building in launchpad

We recently switched to building with golang-1.10. When using this
package there is no "go" binary in the PATH so we must setup the
PATH correctly in our go build plugin.

tests-enable-debian-sid-2 2019-01-25 11:39:44 UTC 2019-01-25
tests: restart systemd-journald between tests to workaround memleak

Author: Michael Vogt
Author Date: 2019-01-25 07:50:23 UTC

tests: restart systemd-journald between tests to workaround memleak

no-pipefail-again 2019-01-24 16:38:17 UTC 2019-01-24
Merge remote-tracking branch 'upstream/master' into no-pipefail-again

Author: Michael Vogt
Author Date: 2019-01-24 16:38:17 UTC

Merge remote-tracking branch 'upstream/master' into no-pipefail-again

dbus-slot-spread-test 2019-01-23 19:43:21 UTC 2019-01-23
tests: only use dbus-send to the snap service on classic

Author: Michael Vogt
Author Date: 2019-01-23 19:43:21 UTC

tests: only use dbus-send to the snap service on classic

cmd-run-suite 2019-01-23 15:36:17 UTC 2019-01-23
snap: really run the RunSuite

Author: Michael Vogt
Author Date: 2019-01-23 15:35:50 UTC

snap: really run the RunSuite

import-debian-salsa-no-history-w-zyga 2019-01-23 08:24:54 UTC 2019-01-23
import work from salsa.debian.org/zyga-guest/snapd

Author: Michael Vogt
Author Date: 2019-01-23 08:24:54 UTC

import work from salsa.debian.org/zyga-guest/snapd

go.10-2 2019-01-22 07:38:45 UTC 2019-01-22
Update run-checks

Author: John R. Lenton
Author Date: 2019-01-22 07:38:45 UTC

Update run-checks

Co-Authored-By: mvo5 <michael.vogt@gmail.com>

dbus-from-beta 2019-01-21 16:54:49 UTC 2019-01-21
tests: get test-snapd-dbus-{provider,consumer} from the beta channel

Author: Michael Vogt
Author Date: 2019-01-21 16:54:46 UTC

tests: get test-snapd-dbus-{provider,consumer} from the beta channel

We currently get test-snapd-dbus-{provider,consumer} from the
edge channel. This means a bad upload to edge (which is auto-build
from the bzr branches) will break the tests.

Test using the beta channel instead.

incr-kill-timeout 2019-01-21 09:01:07 UTC 2019-01-21
spread: increase default kill-timeout to 30min

Author: Michael Vogt
Author Date: 2019-01-21 08:54:50 UTC

spread: increase default kill-timeout to 30min

On some arches like arm64 preparing the suite may take more than the
20min and the tests run into a timeout. This PR increases the
default kill time to 30min. We could also set it per backend, e.g.
just for "external" and "autopkgtest" but once we get direct spread
support for arm/arm64 we will hit this limit again so increasing
the global timeout seems best.

remodel-v0-with-api 2019-01-18 12:16:30 UTC 2019-01-18
many: add remodel API, `snap remodel` CLI and spead test

Author: Michael Vogt
Author Date: 2019-01-18 12:09:44 UTC

many: add remodel API, `snap remodel` CLI and spead test

remodel-v0-spread 2019-01-18 12:09:44 UTC 2019-01-18
many: add remodel API, `snap remodel` CLI and spead test

Author: Michael Vogt
Author Date: 2019-01-18 12:09:44 UTC

many: add remodel API, `snap remodel` CLI and spead test

import-debian-salsa-no-history 2019-01-18 10:28:42 UTC 2019-01-18
tests: disable some tests in debian-sid

Author: Michael Vogt
Author Date: 2019-01-18 10:28:42 UTC

tests: disable some tests in debian-sid

import-debian-salsa 2019-01-17 17:03:52 UTC 2019-01-17
debian: do not include vendor/ dir in orig.tar.gz

Author: Michael Vogt
Author Date: 2019-01-17 17:03:52 UTC

debian: do not include vendor/ dir in orig.tar.gz

debian 2019-01-17 11:57:08 UTC 2019-01-17
Merge remote-tracking branch 'salsa/debian' into debian

Author: Michael Vogt
Author Date: 2019-01-17 11:57:08 UTC

Merge remote-tracking branch 'salsa/debian' into debian

release-2.37 2019-01-16 18:47:21 UTC 2019-01-16
Merge remote-tracking branch 'upstream/master' into release-2.37

Author: Michael Vogt
Author Date: 2019-01-16 18:46:01 UTC

Merge remote-tracking branch 'upstream/master' into release-2.37

network-control-in-confiure-hook-test 2019-01-16 13:56:13 UTC 2019-01-16
address review feedback (thanks to Jamie!)

Author: Michael Vogt
Author Date: 2019-01-16 13:56:13 UTC

address review feedback (thanks to Jamie!)

fix-silly-typo 2019-01-16 11:00:24 UTC 2019-01-16
debian: fix silly typo in the spread test invocation

Author: Michael Vogt
Author Date: 2019-01-16 11:00:24 UTC

debian: fix silly typo in the spread test invocation

sanity-for-sanity-test 2019-01-16 10:39:41 UTC 2019-01-16
snapd: fix race in TestSanityFailGoesIntoDegradedMode test

Author: Michael Vogt
Author Date: 2019-01-16 10:22:44 UTC

snapd: fix race in TestSanityFailGoesIntoDegradedMode test

Ensure the MockSanityCheck code runs at least *twice* to
avoid a race in the TestSanityFailGoesIntoDegradedMode test:

If we close the channel and this wakes up the "select"
in the test immediately and stops this go-routine, then the
check that the logbuf contains the error will fail.
By running this at least twice we know the error made
it to the log.

smoke-suite 2019-01-16 06:45:05 UTC 2019-01-16
tests: fix smoke/sandbox test on ubuntu-core

Author: Michael Vogt
Author Date: 2019-01-16 06:45:05 UTC

tests: fix smoke/sandbox test on ubuntu-core

fix-gpio-test 2019-01-15 06:33:07 UTC 2019-01-15
tests: add comment in enable-disable-units-gpio

Author: Michael Vogt
Author Date: 2019-01-15 06:33:07 UTC

tests: add comment in enable-disable-units-gpio

adt-fixes-2.37-2 2019-01-14 06:46:08 UTC 2019-01-14
tests: exclude some more slow tests from runs in autopkgtest

Author: Michael Vogt
Author Date: 2019-01-14 06:39:39 UTC

tests: exclude some more slow tests from runs in autopkgtest

The i386 autopkgtest run failed in disco with a timeout error.
This PR removes some more tests from the set of tests run in
the autopkgtest backend to bring the time below the timeout.

Note that the autopkgtest environment on i386/amd64 is
exceedingly slow in the ADT cloud, most likely because of
overcommit of resources there.

release-2.37.pre1 2019-01-10 21:36:57 UTC 2019-01-10
Merge remote-tracking branch 'upstream/master' into release-2.37.pre1

Author: Michael Vogt
Author Date: 2019-01-10 21:36:57 UTC

Merge remote-tracking branch 'upstream/master' into release-2.37.pre1

adt-fixes-2.37 2019-01-10 18:09:36 UTC 2019-01-10
tests: re-enable install-store in ADT, disable snapctl-services/nfs-support

Author: Michael Vogt
Author Date: 2019-01-10 18:09:36 UTC

tests: re-enable install-store in ADT, disable snapctl-services/nfs-support

aligned-info-split 2019-01-10 10:04:45 UTC 2019-01-10
snap: split alignment calculation and display for channels

Author: Michael Vogt
Author Date: 2019-01-10 10:04:45 UTC

snap: split alignment calculation and display for channels

This is a bit of an RFC - it splits the channel display into
a first data gathering phase and a subsequent display phase.

This makes it (IMHO) easier to read the indent code for rev
and size because how the tasks of gathering the channel data
and the task of calculating the indent are stronger separated.

I hope this is useful, happy to also see it just as a starting
point for further work (or maybe even as inspiration :)

snapd-daemon-reload-gil 2019-01-10 06:54:59 UTC 2019-01-10
tests/main/mount-protocol-error: shellchecks

Author: Maciej Borzecki
Author Date: 2019-01-10 06:54:59 UTC

tests/main/mount-protocol-error: shellchecks

Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>

fix-dirname-usage 2019-01-09 08:51:25 UTC 2019-01-09
snap-confine: fix incorrect use "src" var in mount-support.c

Author: Michael Vogt
Author Date: 2019-01-09 08:51:21 UTC

snap-confine: fix incorrect use "src" var in mount-support.c

We got a bugreport from fedora that gcc-9 fails to build with
current snapd:
```
snap-confine/mount-support.c: In function 'sc_bootstrap_mount_namespace':
snap-confine/mount-support.c:403:4: error: '%s' directive argument is null [-Werror=format-overflow=]
  403 | die("cannot use result from readlink: %s", src);
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:2507: snap-confine/snap_confine_debug-mount-support.o] Error 1
make[1]: *** Waiting for unfinished jobs....
```

This PR fixes this issue.

dotfiles-interface 2019-01-07 16:30:09 UTC 2019-01-07
Merge remote-tracking branch 'upstream/master' into dotfiles-interface

Author: Michael Vogt
Author Date: 2019-01-07 16:30:09 UTC

Merge remote-tracking branch 'upstream/master' into dotfiles-interface

core18-only-restart-when-needed-2 2018-12-18 19:07:41 UTC 2018-12-18
fix whitespace

Author: Samuele Pedroni
Author Date: 2018-12-18 19:07:41 UTC

fix whitespace

image-cloudy 2018-12-14 15:00:46 UTC 2018-12-14
image: do not write empty etc/cloud

Author: Michael Vogt
Author Date: 2018-12-14 14:55:38 UTC

image: do not write empty etc/cloud

The `snap --prepare-image` command will currently look into the
gadget and create a /etc/cloud/cloud.cfg configuration if the
gadget contains a "cloud.conf" file in cloud-init format. But
even if there is no such file an empty /etc/cloud directory is
created.

This empty directory ends up on /writable/system-data/etc/cloud
and that will block the initial boot from populating that dir
with the data from the core18 /etc/cloud directory when this
dir is in "transition" mode in the /etc/system-image/writable-paths.

As a first step we should not create this /etc/cloud directory if
there is nothing in it. This means we will be able to revert:
https://github.com/snapcore/core18/pull/106

Once that is done we need to also support ds-identify.conf or
switch to a cloud.conf/ directory instead of the current file
only approach. The reason is that we do not want to merge the
cloud config from core18 and from the gadget as this is messy.
Instead it should either come from the gadget or from the core18.

release-2.36.3 2018-12-14 11:56:58 UTC 2018-12-14
Merge remote-tracking branch 'upstream/master' into release-2.36.3

Author: Michael Vogt
Author Date: 2018-12-14 11:56:58 UTC

Merge remote-tracking branch 'upstream/master' into release-2.36.3

systemd-is-active-tests 2018-12-14 06:51:54 UTC 2018-12-14
systemd/systemd.go: add missing tests for systemd.IsActive

Author: Michael Vogt
Author Date: 2018-12-14 06:38:55 UTC

systemd/systemd.go: add missing tests for systemd.IsActive

This adds the missing tests for the new systemd.IsActive
code.

core18-use-is-active-in-firstboot 2018-12-13 11:57:02 UTC 2018-12-13
Merge remote-tracking branch 'upstream/master' into core18-use-is-active-in-f...

Author: Michael Vogt
Author Date: 2018-12-13 11:57:02 UTC

Merge remote-tracking branch 'upstream/master' into core18-use-is-active-in-firstboot

retry-on-dns 2018-12-13 10:29:14 UTC 2018-12-13
adjust test for the core case

Author: Samuele Pedroni
Author Date: 2018-12-13 10:29:14 UTC

adjust test for the core case

core18-only-restart-when-needed 2018-12-13 09:43:36 UTC 2018-12-13
address review feedback

Author: Michael Vogt
Author Date: 2018-12-13 09:43:36 UTC

address review feedback

systemd-only-stop-if-active 2018-12-13 08:31:38 UTC 2018-12-13
systemd: only stop a unit if its active

Author: Michael Vogt
Author Date: 2018-12-13 08:31:38 UTC

systemd: only stop a unit if its active

snapd-gil 2018-12-12 21:03:12 UTC 2018-12-12
snapstate/backend: make {add,remove}MountUnit part of the backend

Author: Michael Vogt
Author Date: 2018-12-12 21:03:12 UTC

snapstate/backend: make {add,remove}MountUnit part of the backend

no-restart 2018-12-12 19:15:55 UTC 2018-12-12
systemd: start snapd.autoimport.service in --no-block mode

Author: Michael Vogt
Author Date: 2018-12-12 18:40:29 UTC

systemd: start snapd.autoimport.service in --no-block mode

When seeding in core18 we need to make sure that the
snadpd.autoimport.service is started in non-blocking mode. Otherwise
it would wait forever because it has a "After=snapd.seeding.service"
but the snapd.seeding.service will only finish if the code that
writes the core18 snapd units can run. So this prevents a deadlock.

Note that by starting it with --no-block the right thing will happen,
i.e. the unit is starting but waits until the snapd.seeded.service
is done and then it will run (which is what we want).

interface-tweak-tests 2018-12-10 11:10:57 UTC 2018-12-10
interfaces: tweak deny-auto-connect policy tests

Author: Michael Vogt
Author Date: 2018-11-16 08:22:42 UTC

interfaces: tweak deny-auto-connect policy tests

This converts all deny-auto-connect plug tests into a single table
driven test - less repetition and easier to extend.

killmode-process 2018-12-05 12:02:32 UTC 2018-12-05
spread: detect "signal: terminated" in journal logs

Author: Zygmunt Krynicki
Author Date: 2018-11-28 14:23:41 UTC

spread: detect "signal: terminated" in journal logs

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>

snap-run-perf 2018-11-30 11:23:17 UTC 2018-11-30
strace: fix imports ordering

Author: Michael Vogt
Author Date: 2018-11-30 11:23:17 UTC

strace: fix imports ordering

release-2.36.2 2018-11-29 13:16:43 UTC 2018-11-29
Merge remote-tracking branch 'upstream/master' into release-2.36.2

Author: Michael Vogt
Author Date: 2018-11-29 13:16:43 UTC

Merge remote-tracking branch 'upstream/master' into release-2.36.2

systemd-run-security-gen 2018-11-29 13:11:18 UTC 2018-11-29
WIP: use systemd-run to write security profiles

Author: Michael Vogt
Author Date: 2018-11-29 13:11:18 UTC

WIP: use systemd-run to write security profiles

fix-bogus-date 2018-11-29 10:23:57 UTC 2018-11-29
packaging/fedora/snapd.spec: fix bogus date in changelog

Author: Michael Vogt
Author Date: 2018-11-29 10:23:21 UTC

packaging/fedora/snapd.spec: fix bogus date in changelog

run-fontconfig 2018-11-28 18:01:18 UTC 2018-11-28
add TODO

Author: Samuele Pedroni
Author Date: 2018-11-28 18:01:18 UTC

add TODO

run-fontconfig-2.36-mode 2018-11-28 14:42:45 UTC 2018-11-28
spread: detect "signal: terminated" in journal logs

Author: Zygmunt Krynicki
Author Date: 2018-11-28 14:23:41 UTC

spread: detect "signal: terminated" in journal logs

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>

run-fontconfig-2.36-with-security-backend-mocking 2018-11-28 11:55:23 UTC 2018-11-28
overlord,daemon: mock security backends for testing

Author: Zygmunt Krynicki
Author Date: 2018-11-28 10:08:40 UTC

overlord,daemon: mock security backends for testing

Testing the overlord involves initializing the overlord, which in turn
does the same to each of the managers. The interface manager is
particularly active during the initialization phase. It will initialize
all the security backends, some which deeply interrogate the system .
It will compute and compare the system key. Lastly it will regenerate
security profiles for all the snaps if said profile is mismatching. When
setting up core the apparmor security backend performs special handling
for the snap-confine program running from core or from snapd snaps.

All of that interacts with the system. While we could, with enough
effort, mock it away at a very fine grained level we could just replace
all the real security backends with a test backend. This is easy and has
no consequences because we were not measuring anything about the
interactions of the security backend anyway.

This patch does just that. In addition, now-useless mocking of various
system commands has been removed.

Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>

run-fontconfig-2.36 2018-11-27 08:28:09 UTC 2018-11-27
snapstate: only run fontconfig update on classic

Author: Michael Vogt
Author Date: 2018-11-26 08:22:50 UTC

snapstate: only run fontconfig update on classic

disable-funcargs-for-now 2018-11-26 11:45:23 UTC 2018-11-26
spread.yaml: disable _/funcarg test for now

Author: Michael Vogt
Author Date: 2018-11-26 11:45:23 UTC

spread.yaml: disable _/funcarg test for now

dotfiles-interface-tweak-tests 2018-11-26 09:16:32 UTC 2018-11-26
Merge remote-tracking branch 'upstream/master' into dotfiles-interface-tweak-...

Author: Michael Vogt
Author Date: 2018-11-26 09:16:32 UTC

Merge remote-tracking branch 'upstream/master' into dotfiles-interface-tweak-tests

gpio-updates-core18 2018-11-21 08:58:42 UTC 2018-11-21
Merge remote-tracking branch 'origin/master' into pull/6166

Author: Maciej Borzecki
Author Date: 2018-11-21 08:58:42 UTC

Merge remote-tracking branch 'origin/master' into pull/6166

snap-debug-start-time 2018-11-21 07:16:32 UTC 2018-11-21
snap,snap-exec: add SNAP_DEBUG_START_TIME environment

Author: Michael Vogt
Author Date: 2018-11-21 07:06:59 UTC

snap,snap-exec: add SNAP_DEBUG_START_TIME environment

This helps analyzing the startup overhead that snap-{run,confine,exec}
impose on top of the actual application. Its important to measure
this to know what part of the startup is the snapcraft wrappers and
what part is our own namespace setup.

snap-remove-remove-desktop 2018-11-20 07:32:13 UTC 2018-11-20
Merge remote-tracking branch 'upstream/master' into snap-remove-remove-desktop

Author: Michael Vogt
Author Date: 2018-11-20 07:32:13 UTC

Merge remote-tracking branch 'upstream/master' into snap-remove-remove-desktop

tinyproxy-notify 2018-11-20 06:25:11 UTC 2018-11-20
tests: make tinyproxy support systemd notify

Author: Michael Vogt
Author Date: 2018-11-20 06:25:07 UTC

tests: make tinyproxy support systemd notify

The tinyproxy has a bit of a startup delay (python init and all that).
This means that sometimes in tests the proxy is not fully ready when
the test tries to talk to it. This PR makes the proxy a "notify"
service that only notifies after the proxy is ready.

gpio-updates-2 2018-11-19 11:19:07 UTC 2018-11-19
tests: add SPREAD_JOB to the description of systemd_create_and_start_unit

Author: Michael Vogt
Author Date: 2018-11-19 11:18:12 UTC

tests: add SPREAD_JOB to the description of systemd_create_and_start_unit

gpio-for-core18 2018-11-16 17:20:41 UTC 2018-11-16
tests: run gpio test on core18

Author: Michael Vogt
Author Date: 2018-11-16 15:50:23 UTC

tests: run gpio test on core18

Also add the gpio to the gadget interface to get a more realistic
test (the gadget is defining this on the Pi).

gpio-updates 2018-11-16 12:32:47 UTC 2018-11-16
tests: improve robustness of enable-disable-units-gpio

Author: Michael Vogt
Author Date: 2018-11-16 11:49:07 UTC

tests: improve robustness of enable-disable-units-gpio

snap-rename-desktop-files-to-apps 2018-11-16 10:37:35 UTC 2018-11-16
wrappers: rename the desktop file to their apps

Author: Michael Vogt
Author Date: 2018-11-16 10:37:35 UTC

wrappers: rename the desktop file to their apps

min-snap-name-len 2018-11-16 08:37:44 UTC 2018-11-16
Merge remote-tracking branch 'upstream/master' into min-snap-name-len

Author: Michael Vogt
Author Date: 2018-11-16 08:37:44 UTC

Merge remote-tracking branch 'upstream/master' into min-snap-name-len

zenity-min-width 2018-11-15 11:12:10 UTC 2018-11-15
userd: force zenity width if the text displayed is long

Author: Michael Vogt
Author Date: 2018-11-15 11:12:07 UTC

userd: force zenity width if the text displayed is long

Gtk is not doing a good job with long labels. It will
create a very narrow and long window (minimal width to fit
the buttons). So force a bigger width when there is a lot
of text. See also LP: 1778484

1100 of 1849 results
This repository contains Public information 
Everyone can see this information.

Subscribers