snapd

~mvo/snapd/+git/snapd-mvo:followup-lp12939

  1. Git
  2. lp:~mvo/snapd/+git/snapd-mvo
  3. followup-lp12939
Last commit made on 2023-07-10
Get this branch:
git clone -b followup-lp12939 https://git.launchpad.net/~mvo/snapd/+git/snapd-mvo

Branch merges

Branch information

Name:
followup-lp12939
Repository:
lp:~mvo/snapd/+git/snapd-mvo

Recent commits

12e6b2e... by Michael Vogt

install: extract unmount helper function

In the review of PR#12939 extracting a common helper for unmounting
was suggested. This commit extracts a new `unmountWithFallbackToLazy`
helper that first tries to do a normal unmount and then falls
back to `syscall.MNT_DETACH` which is the same as `umount --lazy`.
It will ensure the mountpoint will be released in the kernel once
there are no longer any processes keeping it busy.

18f82a8... by Michael Vogt

advisor: add a small unittest

Now that we have the codecov metrics back I noticed that the
advisor/backend.go code has no tests for the rollback functionality.

This commit adds a simple testcase.

cb63090... by Michael Vogt

interface: partly revert network-control apparmor change (ee7e554)

This commit reverts the commenting out of the rule:
```
mount options=(rw, rslave) /,
```
This was broken in apparmor 3.1.4 but got fixed in 3.1.5.

2bef6c5... by Michael Vogt

go.mod: update gopkg.in/yaml.v3 to v3.0.1 to fix CVE-2022-28948

7ba95e3... by Sergio Cazzolato

tests: speed up the prepare phase through a new tool to manage initial snapd env (#12707)

* New tool to manage initial env in spread tests

This is used to know in spread tests the initial value for the vars and
be able to repeat not needed steps

* test fixed

* Minor fixes con docs and env var removed

* improve tests.env tool

4640067... by Miguel Pires

.github: fix exempted bot name

Signed-off-by: Miguel Pires <email address hidden>

5c9d870... by Miguel Pires

.github: ignore translations committer in CLA check

Signed-off-by: Miguel Pires <email address hidden>

7e22ca9... by Sergio Cazzolato

Skip uc20-create-partitions-encrypt in ubuntu-23.*

This skip is required because the test is getting stuck

/usr/lib/snapd/snap-fde-keymgr add-recovery-key --key-file
/home/gopath/src/github.com/snapcore/snapd/tests/main/uc20-create-partitions-encrypt/recovery-key
--devices /dev/loop1p5 --authorizations
file:/home/gopath/src/github.com/snapcore/snapd/tests/main/uc20-create-partitions-encrypt/unsealed-key
--devices /dev/loop1p4 --authorizations
file:/home/gopath/src/github.com/snapcore/snapd/tests/main/uc20-create-partitions-encrypt/save-key

Getting stuck in keymgr_luks3.go
if err := luks2.AddKey(dev, currKey, recoveryKey[:], &options); err !=
nil {
 return fmt.Errorf("cannot add key: %v", err)
}

dev: /dev/loop1p5
currKey: [147 82 161 187 119 61 54 50 164 67 214 97 112 65 122 24 186
176 1 239 110 94 3 108 52 204 252 215 105 68 53 245]
recoveryKey: [135 240 162 165 227 144 234 164 196 133 220 32 104 174 169
112]
options: {{0s 1048576 4 0} 1}

7f0bcdf... by Michael Vogt

snap-bootstrap: print version information at startup

We got asked to print the version information of snap-bootstrap
during the boot to help the enablement/field team to know if
they are using the right version of snap-bootstrap.

This is a small commit that archives this. It uses the logger
so quiet boot will also be honored.

e3215d6... by Robert P. J. Day

daemon.go: doc cleanup

Signed-off-by: Robert P. J. Day <email address hidden>