~mvo/snapd/+git/snapd-mvo:remove-dead-code3

Last commit made on 2023-07-19
Get this branch:
git clone -b remove-dead-code3 https://git.launchpad.net/~mvo/snapd/+git/snapd-mvo

Branch merges

Branch information

Name:
remove-dead-code3
Repository:
lp:~mvo/snapd/+git/snapd-mvo

Recent commits

8dc82bd... by Michael Vogt

preseed: remove unneeded error check after sd.EssentialSnaps()

There is no need to check `sd.EssentialSnaps()` as it does not
return an error.

9431b3f... by Zeyad Gouda

daemon: modify unit tests of TestErrToResponse to test multiple snaps

This modification is needed to test the edge case of having one snap
failing with ErrSnapNotFound and another snap being successful.
It used to return 500 error instead of the more useful 404.

For context see: https://bugs.launchpad.net/snapd/+bug/2024858

Signed-off-by: Zeyad Gouda <email address hidden>

5d2877e... by Zeyad Gouda

daemon: fix /v2/snaps "Internal Server Error" error when installing unknown snaps

Internal Server Error response was returned when only one of many snaps is
not found. The problem was passing all snap names (including succesful ones)
to errToResponse instead of the unknown snap only.

In the following example only "spamandeggs" is not found, 404 status code is
expected, 500 is returned instead:
curl -sS --unix-socket /run/snapd.socket http://localhost/v2/snaps -X POST \
-d '{"action": "install", "snaps": ["spamandeggs", "hello"]}' -H "Content-Type: application/json" \
| jq
> {
> "type": "error",
> "status-code": 500,
> "status": "Internal Server Error",
> "result": {
> "message": "store.SnapNotFound with 2 snaps"
> }
> }

Fixes: https://bugs.launchpad.net/snapd/+bug/2024858

Signed-off-by: Zeyad Gouda <email address hidden>

a314160... by Dimitri John Ledkov <email address hidden>

interfaces: allow suppressing pycache deny rule (#12822)

* interfaces: Allow suppressing pycache deny rule

Fully confined snaps, and docker containers, look very similar. As
moveroot/pivotroot/chroot is changed, and apparmor confinement
applied. Yet confined snaps constantly try to write to .pyc files of
the base snap, whereas docker containers are trying to write .pyc
files inside the child docker containers... and yet both are
denied. Whilst former is undesired, the latter is very confusing.

Attempt to address
https://github.com/docker-snap/docker-snap/issues/81 without
disrupting intent of LP: #1496895

Introduce a new inline template replacement for pycache deny rules
(such that all existing snippet tests remain intact), and make
docker-support interface suppress pycache deny rules.

* Fix comment typo

---------

Co-authored-by: Michael Vogt <email address hidden>

994c4e7... by Philip Meulengracht

many: carry bootloader options in rebootinfo

Instead of carrying an interface, carry the bootloader options we need to find it later.

45f2ee2... by Philip Meulengracht

t/regression/mount-order-regression: set no mem limit

Unfortunately it happens that we hit the memory limit while setting up security profiles for the snap. Set no memory limit for this test

0ee6c91... by Philip Meulengracht

t/core/snapd-failover: use SIGKILL instead of SIGSEGV

We should avoid triggering of the segmentation fault check

5029c45... by Philip Meulengracht

tests/lib/tools: use correct unit switch

9b6039c... by Michael Vogt

tests: make `strace-static` channel point to beta

The current strace-static edge channel is unhappy so let's switch
to `--beta` until this is fixed.

0622b61... by Michael Vogt

gadget: fix TestMountVolumesLazyUnmount after master branch update