Merge lp:~mvo/command-not-found/install-prompt-env into lp:~command-not-found-developers/command-not-found/trunk

[Michael Vogt]

This branch makes the install prompt conditional on the environemt COMMAND_NOT_FOUND_INSTALL_PROMPT as not everybody likes this new interactive feature.

[Zygmunt Krynicki (zyga)]

Thanks, +1

review: Approve

[voltlick (luke-stanley)]

The default is not helpful to most people. This patch should be reversed.
I'm also considering asking the user if copying "sudo apt-get install [whatever command]" to the clipboard or bash history should be done as that may be faster than debating here.

review: Disapprove

[Chozabu (chozabu)]

Seconded, I think most people would prefer:

        if "DISABLE_COMMAND_NOT_FOUND_INSTALL_PROMPT" in os.environ:
            return

to
        if not "COMMAND_NOT_FOUND_INSTALL_PROMPT" in os.environ:
            return

Those that don't like the prompt would be much more apt at disabling it than those don't even know of its existence.
It's good to have the option to disable, but why by default?

review: Needs Fixing

[voltlick (luke-stanley)]

review: Needs Fixing

=== modified file 'CommandNotFound/CommandNotFound.py'
--- CommandNotFound/CommandNotFound.py	2011-12-09 22:56:07 +0000
+++ CommandNotFound/CommandNotFound.py	2012-01-12 09:19:06 +0000
@@ -191,6 +191,8 @@
         return (yidx - xidx) or cmp(x, y)
 
     def install_prompt(self, package_name):
+        if not "COMMAND_NOT_FOUND_INSTALL_PROMPT" in os.environ:
+            return
         if package_name:
             answer = raw_input(_("Do you want to install it? (N/y)"))
             if sys.stdin.encoding and isinstance(answer, str):
 
=== modified file 'README'
--- README	2007-03-20 17:06:10 +0000
+++ README	2012-01-12 09:19:06 +0000
@@ -1,6 +1,9 @@
 This application implements the command-not-found spec at:
 https://wiki.ubuntu.com/CommandNotFoundMagic
 
+If you want automatic prompts to install the package, set
+COMMAND_NOT_FOUND_INSTALL_PROMPT in your environment.
+
 To use it in bash, please add the following line to your .bashrc file:
 . /etc/bash_command_not_found