Code review comment for lp:~mvo/command-not-found/install-prompt-env

Revision history for this message
Chozabu (chozabu) wrote :

Seconded, I think most people would prefer:

        if "DISABLE_COMMAND_NOT_FOUND_INSTALL_PROMPT" in os.environ:
            return

to
        if not "COMMAND_NOT_FOUND_INSTALL_PROMPT" in os.environ:
            return

Those that don't like the prompt would be much more apt at disabling it than those don't even know of its existence.
It's good to have the option to disable, but why by default?

review: Needs Fixing

« Back to merge proposal