Merge ~mthaddon/postgresql-charm/+git/postgresql-charm:charmcraft into postgresql-charm:master

Proposed by Tom Haddon
Status: Merged
Approved by: Tom Haddon
Approved revision: ac36ef387fb882e6de4962a1f1f3f2eb3adde14d
Merged at revision: a631e83241e0e1d1311de36b3ff5eb8c0a1b8612
Proposed branch: ~mthaddon/postgresql-charm/+git/postgresql-charm:charmcraft
Merge into: postgresql-charm:master
Diff against target: 47 lines (+23/-1)
3 files modified
charmcraft.yaml (+17/-0)
requirements.txt (+2/-1)
wheelhouse.txt (+4/-0)
Reviewer Review Type Date Requested Status
Haw Loeung +1 Approve
Canonical IS Reviewers Pending
Review via email: mp+425160@code.launchpad.net

Commit message

Add a charmcraft.yaml and pin dependencies so this can be built for xenial, bionic, focal

Description of the change

Add a charmcraft.yaml and pin dependencies so this can be built for xenial, bionic, focal

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Haw Loeung (hloeung) wrote :

LGTM. No Jammy support? It's the current LTS ;)

review: Approve (+1)
Revision history for this message
Tom Haddon (mthaddon) wrote :

No, not adding series support in a branch that is just about allowing us to build the charm again :)

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision a631e83241e0e1d1311de36b3ff5eb8c0a1b8612

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/charmcraft.yaml b/charmcraft.yaml
0new file mode 1006440new file mode 100644
index 0000000..6271283
--- /dev/null
+++ b/charmcraft.yaml
@@ -0,0 +1,17 @@
1type: "charm"
2bases:
3 - build-on:
4 - name: "ubuntu"
5 channel: "20.04"
6 run-on:
7 - name: "ubuntu"
8 channel: "16.04"
9 - name: "ubuntu"
10 channel: "18.04"
11 - name: "ubuntu"
12 channel: "20.04"
13parts:
14 charm:
15 source: .
16 plugin: reactive
17 build-snaps: [charm]
diff --git a/requirements.txt b/requirements.txt
index 8bbb991..a324a4e 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -8,7 +8,8 @@ jinja2
8juju-wait8juju-wait
9python-swiftclient9python-swiftclient
10charms.reactive10charms.reactive
11charmhelpers11# Needed to support xenial per https://discourse.charmhub.io/t/removing-py27-p35-from-charm-helpers-library/5335
12charmhelpers<1.2.0
12juju-deployer13juju-deployer
13pip14pip
14websocket-client15websocket-client
diff --git a/wheelhouse.txt b/wheelhouse.txt
15new file mode 10064416new file mode 100644
index 0000000..de27c62
--- /dev/null
+++ b/wheelhouse.txt
@@ -0,0 +1,4 @@
1# Needed to support xenial per https://discourse.charmhub.io/t/removing-py27-p35-from-charm-helpers-library/5335
2charmhelpers<1.2.0
3# Needed for xenial support - MarkupSafe 2.x only support python3.6 and greater
4MarkupSafe<2.0.0

Subscribers

People subscribed via source and target branches

to all changes: