Code review comment for lp:~mterry/ubuntu-system-settings/wizard-refresh-take-6
Revision history for this message
| Michael Terry (mterry) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
> entering the passcode seems to display another label in the bottom/right button for a second before changing page (I couldn't manage to read it but it seems to change geometry/looks weird)
I *think* I see what you mean -- but it's after the next page (Wi-Fi) starts loading, not before. It looks like the button goes from Continue->Skip. Which it does. I've looked at the code and understand why it would. But we'd need to do something slightly fancy there to fix it:
A) Add a way to tell if a UnityMenuModel has finished asking for content over DBus or
B) Delay showing the button for a second, but that feels a little hackish
> the enter passcode screen has a skip button, is that by design?
Yes, it switches to Swipe mode if pressed.
> the design got updated to address bug #1374504, can we include that as well (change the "report a bug" for "improve the experience")
Fixed.
> the wifi page has a label "no network available" before the aps list, dispite having quite some items in the list and being connected to one, do you see that as well?
Fixed. It was odd, the count for the model wasn't correct but the count for the repeater was. I'm not sure when that broke, but I just used the repeater count instead.