Code review comment for lp:~mterry/geonames/translations

Revision history for this message
Josh Arenson (josharenson) wrote :

Not quite done with the review, but I have the silo on my phone and I'm playing with it. I thought I'd change my phone to Hebrew as it is non-latin, right-to-left justified, and I can read it (the ultimate edge case). With my phone's language in Hebrew, and using a Hebrew keyboard, no results are returned for any of my queries. I've checked that the places I'm searching for are in the alternateNames file as well.

In addition:

The licenses in the modified files still list the author. I don't know if you left this on purpose. All the source files _are_ consistent.

** geonames-query.c **
line 142 - env_locale is unused
line 143 - env_lang is unused

(still have a bit to review, hang on till tomorrow)

review: Needs Fixing

« Back to merge proposal