Code review comment for lp:~mrazik/unity/coverage-support

Revision history for this message
Martin Mrazik (mrazik) wrote :

> I can't run make check because it errors out with "No rule to make target
> `../tests/test-gtest', needed by `tests/CMakeFiles/check'. Stop." However if
> I just run "make coverage-xml", I get an XML file with no real content in it.
>
> It would be nice if this was done automatically (by e.g. having a dependency
> between coverity-xml and tests) but I assume that Jenkins will automatically
> run these in the correct order so adding the dependency would run the tests
> twice.
>
> This is not a blocker in any case, just would-be-nice-to-have speculation.

I would prefer to leave this is up to you guys. TBH a coverage-html target should be also created (which would be using lcov) so you can check the coverage locally as well. This is a minimal support for coverage for jenkins. Not much more than that.

« Back to merge proposal