Merge lp:~mrazik/unity/coverage-support into lp:unity
Proposed by
Martin Mrazik
Status: | Merged |
---|---|
Approved by: | Jussi Pakkanen |
Approved revision: | no longer in the source branch. |
Merged at revision: | 2941 |
Proposed branch: | lp:~mrazik/unity/coverage-support |
Merge into: | lp:unity |
Diff against target: |
29 lines (+19/-0) 1 file modified
CMakeLists.txt (+19/-0) |
To merge this branch: | bzr merge lp:~mrazik/unity/coverage-support |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jussi Pakkanen (community) | Approve | ||
PS Jenkins bot | continuous-integration | Pending | |
Thomas Voß | Pending | ||
Review via email: mp+136345@code.launchpad.net |
Commit message
Adding -DCMAKE_
Description of the change
= Problem description =
This adds code coverage support to the build system by adding -DCMAKE_
= The fix =
CMakeLists.txt only change.
= Test coverage =
Build with -DCMAKE_
https:/
Build log without -DCMAKE_
https:/
To post a comment you must log in.
The if clause on line 18 is incorrect and always evaluates to true. It should be written like this:
if (NOT GCOVR_EXECUTABLE)
Also, trying to run coverity tests without gcovr is an error. It does not provide any useful data, and only wastes time. The build system should stop with an error. This is simple, just change line 19 to this:
message(FATAL_ERROR "Cannot enable coverage targets because gcovr was not found.")