Code review comment for lp:~mrazik/unity/coverage-support

Revision history for this message
Martin Mrazik (mrazik) wrote :

> The if clause on line 18 is incorrect and always evaluates to true. It should
> be written like this:
>
> if (NOT GCOVR_EXECUTABLE)
>
> Also, trying to run coverity tests without gcovr is an error. It does not
> provide any useful data, and only wastes time. The build system should stop
> with an error. This is simple, just change line 19 to this:
>
> message(FATAL_ERROR "Cannot enable coverage targets because gcovr was not
> found.")

Thanks. These are fixed.

« Back to merge proposal