ubiquity

Merge lp:~mpt/ubiquity/1283047-field-labels into lp:ubiquity

  1. 1283047-field-labels
  2. Merge into trunk
Proposed by Matthew Paul Thomas
Status: Merged
Merged at revision: 6122
Proposed branch: lp:~mpt/ubiquity/1283047-field-labels
Merge into: lp:ubiquity
Diff against target: 35 lines (+0/-4)
1 file modified
gui/gtk/stepUserInfo.ui (+0/-4)
To merge this branch: bzr merge lp:~mpt/ubiquity/1283047-field-labels
Reviewer Review Type Date Requested Status
Dimitri John Ledkov Approve
Review via email: mp+207646@code.launchpad.net

Description of the change

Removes redundant placeholder labels from the "Who are you?" step. The fields already have labels outside.

To post a comment you must log in.
lp:~mpt/ubiquity/1283047-field-labels updated
6116. By Matthew Paul Thomas

Removes the redundant 'Your name' placeholder as well.

Revision history for this message
Dimitri John Ledkov (xnox) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'gui/gtk/stepUserInfo.ui'
--- gui/gtk/stepUserInfo.ui 2012-02-17 13:49:17 +0000
+++ gui/gtk/stepUserInfo.ui 2014-02-21 13:51:22 +0000
@@ -157,7 +157,6 @@
157 <property name="activates_default">True</property>157 <property name="activates_default">True</property>
158 <property name="width_chars">20</property>158 <property name="width_chars">20</property>
159 <property name="invisible_char_set">True</property>159 <property name="invisible_char_set">True</property>
160 <property name="placeholder_text">Password</property>
161 <accessibility>160 <accessibility>
162 <relation type="labelled-by" target="password_label"/>161 <relation type="labelled-by" target="password_label"/>
163 </accessibility>162 </accessibility>
@@ -202,7 +201,6 @@
202 <property name="activates_default">True</property>201 <property name="activates_default">True</property>
203 <property name="width_chars">20</property>202 <property name="width_chars">20</property>
204 <property name="invisible_char_set">True</property>203 <property name="invisible_char_set">True</property>
205 <property name="placeholder_text">Confirm password</property>
206 <accessibility>204 <accessibility>
207 <relation type="labelled-by" target="verified_password_label"/>205 <relation type="labelled-by" target="verified_password_label"/>
208 </accessibility>206 </accessibility>
@@ -257,7 +255,6 @@
257 <property name="invisible_char">•</property>255 <property name="invisible_char">•</property>
258 <property name="activates_default">True</property>256 <property name="activates_default">True</property>
259 <property name="width_chars">40</property>257 <property name="width_chars">40</property>
260 <property name="placeholder_text">Your name</property>
261 <accessibility>258 <accessibility>
262 <relation type="labelled-by" target="fullname_label"/>259 <relation type="labelled-by" target="fullname_label"/>
263 </accessibility>260 </accessibility>
@@ -298,7 +295,6 @@
298 <property name="invisible_char">•</property>295 <property name="invisible_char">•</property>
299 <property name="activates_default">True</property>296 <property name="activates_default">True</property>
300 <property name="width_chars">15</property>297 <property name="width_chars">15</property>
301 <property name="placeholder_text">Username</property>
302 <accessibility>298 <accessibility>
303 <relation type="labelled-by" target="username_label"/>299 <relation type="labelled-by" target="username_label"/>
304 </accessibility>300 </accessibility>

Subscribers

People subscribed via source and target branches

to status/vote changes: