ubiquity

Merge lp:~mpt/ubiquity/1283047-field-labels into lp:ubiquity

  1. 1283047-field-labels
  2. Merge into trunk
Proposed by Matthew Paul Thomas
Status: Merged
Merged at revision: 6122
Proposed branch: lp:~mpt/ubiquity/1283047-field-labels
Merge into: lp:ubiquity
Diff against target: 35 lines (+0/-4)
1 file modified
gui/gtk/stepUserInfo.ui (+0/-4)
To merge this branch: bzr merge lp:~mpt/ubiquity/1283047-field-labels
Reviewer Review Type Date Requested Status
Dimitri John Ledkov Approve
Review via email: mp+207646@code.launchpad.net

Description of the change

Removes redundant placeholder labels from the "Who are you?" step. The fields already have labels outside.

To post a comment you must log in.
lp:~mpt/ubiquity/1283047-field-labels updated
6116. By Matthew Paul Thomas

Removes the redundant 'Your name' placeholder as well.

Revision history for this message
Dimitri John Ledkov (xnox) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'gui/gtk/stepUserInfo.ui'
2--- gui/gtk/stepUserInfo.ui 2012-02-17 13:49:17 +0000
3+++ gui/gtk/stepUserInfo.ui 2014-02-21 13:51:22 +0000
4@@ -157,7 +157,6 @@
5 <property name="activates_default">True</property>
6 <property name="width_chars">20</property>
7 <property name="invisible_char_set">True</property>
8- <property name="placeholder_text">Password</property>
9 <accessibility>
10 <relation type="labelled-by" target="password_label"/>
11 </accessibility>
12@@ -202,7 +201,6 @@
13 <property name="activates_default">True</property>
14 <property name="width_chars">20</property>
15 <property name="invisible_char_set">True</property>
16- <property name="placeholder_text">Confirm password</property>
17 <accessibility>
18 <relation type="labelled-by" target="verified_password_label"/>
19 </accessibility>
20@@ -257,7 +255,6 @@
21 <property name="invisible_char">•</property>
22 <property name="activates_default">True</property>
23 <property name="width_chars">40</property>
24- <property name="placeholder_text">Your name</property>
25 <accessibility>
26 <relation type="labelled-by" target="fullname_label"/>
27 </accessibility>
28@@ -298,7 +295,6 @@
29 <property name="invisible_char">•</property>
30 <property name="activates_default">True</property>
31 <property name="width_chars">15</property>
32- <property name="placeholder_text">Username</property>
33 <accessibility>
34 <relation type="labelled-by" target="username_label"/>
35 </accessibility>

Subscribers

People subscribed via source and target branches

to status/vote changes: