Merge ~mpontillo/maas:default-lacp-rate-fast--bug-1730751--2.3 into maas:2.3

Proposed by Mike Pontillo
Status: Merged
Approved by: Mike Pontillo
Approved revision: b3f85f0649b3b543e5191c85abb3e40331527389
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~mpontillo/maas:default-lacp-rate-fast--bug-1730751--2.3
Merge into: maas:2.3
Diff against target: 26 lines (+2/-2)
2 files modified
src/maasserver/enum.py (+1/-1)
src/maasserver/forms/tests/test_interface.py (+1/-1)
Reviewer Review Type Date Requested Status
MAAS Lander Approve
Mike Pontillo (community) Approve
Review via email: mp+334142@code.launchpad.net

Commit message

LP: #1730751 - Change the default bond LACP rate to fast.

Backports: ab28dd0b4e2eb45ca1f7fa57b899cbff1894b265

To post a comment you must log in.
Revision history for this message
Mike Pontillo (mpontillo) wrote :

Self-approve backport.

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b default-lacp-rate-fast--bug-1730751--2.3 lp:~mpontillo/maas into -b 2.3 lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: b3f85f0649b3b543e5191c85abb3e40331527389

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/maasserver/enum.py b/src/maasserver/enum.py
2index c00e95f..8b66324 100644
3--- a/src/maasserver/enum.py
4+++ b/src/maasserver/enum.py
5@@ -693,8 +693,8 @@ class BOND_LACP_RATE:
6
7
8 BOND_LACP_RATE_CHOICES = (
9- (BOND_LACP_RATE.SLOW, BOND_LACP_RATE.SLOW),
10 (BOND_LACP_RATE.FAST, BOND_LACP_RATE.FAST),
11+ (BOND_LACP_RATE.SLOW, BOND_LACP_RATE.SLOW),
12 )
13
14
15diff --git a/src/maasserver/forms/tests/test_interface.py b/src/maasserver/forms/tests/test_interface.py
16index 5a293c9..15719f4 100644
17--- a/src/maasserver/forms/tests/test_interface.py
18+++ b/src/maasserver/forms/tests/test_interface.py
19@@ -789,7 +789,7 @@ class BondInterfaceFormTest(MAASServerTestCase):
20 "bond_miimon": 100,
21 "bond_downdelay": 0,
22 "bond_updelay": 0,
23- "bond_lacp_rate": "slow",
24+ "bond_lacp_rate": "fast",
25 "bond_xmit_hash_policy": "layer2",
26 }, interface.params)
27

Subscribers

People subscribed via source and target branches