Code review comment for lp:~mixxxdevelopers/mixxx/features_scriptTimers

Revision history for this message
Adam Davison (adamdavison) wrote :

> > And in fact you aren't sampling the "velocity" of the midi wheels, you're
> > getting discrete delta position numbers from the midi controller. Surely the
> > best approach is to process these scratch deltas as they arrive in some way,
>
> That's exactly my plan, using the alpha-beta filter code already in scratch.*
> script functions. But an alpha-beta filter is a time-sensitive one and without
> interval-based sampling, there is no way to tell it the wheel has stopped, so
> it's starved of data in that case instead of realizing that it needs to
> rapidly decelerate. (That's why in 1.7 it acts so screwy when you just hold
> your finger in one spot on the SCS.3d's red vinyl mode.)

Ok, so the timer basically just provides some kind of nothing-happened-in-this-tick signal to the filter. That all sounds reasonable.

Thanks,

Adam

« Back to merge proposal