lp:~mixxxdevelopers/mixxx/features_scriptTimers
Adding MIDI script timers which allow time-accurate scratching and timed controller reactions like flashing lights.
- Get this branch:
- bzr branch lp:~mixxxdevelopers/mixxx/features_scriptTimers
Branch merges
- RJ Skerry-Ryan: Approve
- Albert Santoni: Needs Fixing
- Sean M. Pappalardo: Needs Resubmitting
-
Diff: 893 lines (+406/-132)10 files modifiedmixxx/res/midi/midi-mappings-scripts.js (+1/-1)
mixxx/src/main.cpp (+4/-0)
mixxx/src/midi/mididevice.cpp (+4/-5)
mixxx/src/midi/mididevice.h (+2/-0)
mixxx/src/midi/midimapping.cpp (+43/-45)
mixxx/src/midi/midimapping.h (+7/-2)
mixxx/src/midi/midimessage.cpp (+1/-0)
mixxx/src/midi/midiscriptengine.cpp (+325/-63)
mixxx/src/midi/midiscriptengine.h (+19/-11)
mixxx/src/mixxx.cpp (+0/-5)
Branch information
Recent revisions
- 2276. By Sean M. Pappalardo
-
- Removed _exit() hack for Windows
- Added "shutdown complete" message for closure - 2274. By Sean M. Pappalardo
-
- Made the midiDebug flag global in the MidiScriptEngine instead of asking the MidiDevice for it each time
- Replaced obsolete canEvaluate() with checkSyntax()
- Mixxx now shows friendly warning dialogs and no longer aborts on script errors (unless run with --midiDebug) - 2273. By Sean M. Pappalardo
-
Addressed RJ's code review concerns:
- got rid of the reference passing between threads and replaced with value passing on signals (it's actually neater this way too)
- moved the lock in gracefulShutdown() to include clearing m_connectedControls
- added lock assert to stopAllTimers() too
- moved the lock in timerEvent to include m_timers[] access
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar RepositoryFormatKnitPack5 (bzr 1.6)
- Stacked on:
- lp:~mixxxdevelopers/mixxx/trunk