Merge lp:~mitya57/ubuntu/saucy/network-manager-applet/autostart into lp:ubuntu/saucy/network-manager-applet

Proposed by Dmitry Shachnev
Status: Merged
Merge reported by: Iain Lane
Merged at revision: not available
Proposed branch: lp:~mitya57/ubuntu/saucy/network-manager-applet/autostart
Merge into: lp:ubuntu/saucy/network-manager-applet
Diff against target: 100 lines (+24/-26)
5 files modified
.pc/applied-patches (+1/-1)
debian/changelog (+6/-0)
debian/patches/do_not_autostart_under_gnome.patch (+13/-23)
debian/patches/series (+1/-1)
nm-applet.desktop.in (+3/-1)
To merge this branch: bzr merge lp:~mitya57/ubuntu/saucy/network-manager-applet/autostart
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+189267@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote :

Already in.

Please continue to work on this issue upstream though.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '.pc/applied-patches'
2--- .pc/applied-patches 2013-09-02 14:03:33 +0000
3+++ .pc/applied-patches 2013-10-04 11:06:18 +0000
4@@ -16,4 +16,4 @@
5 lp1048516_dont_req_keyring_in_greeter.patch
6 lp1048520_delay_pin_dialog_in_greeter.patch
7 rebuild_menu_after_init.patch
8-git_dont_autostart_under_GNOME.patch
9+do_not_autostart_under_gnome.patch
10
11=== renamed directory '.pc/git_dont_autostart_under_GNOME.patch' => '.pc/do_not_autostart_under_gnome.patch'
12=== modified file 'debian/changelog'
13--- debian/changelog 2013-09-02 14:03:33 +0000
14+++ debian/changelog 2013-10-04 11:06:18 +0000
15@@ -1,3 +1,9 @@
16+network-manager-applet (0.9.8.0-1ubuntu4) saucy; urgency=low
17+
18+ * Make sure the applet is still autostarted in GNOME Flashback session.
19+
20+ -- Dmitry Shachnev <mitya57@ubuntu.com> Fri, 04 Oct 2013 14:44:25 +0400
21+
22 network-manager-applet (0.9.8.0-1ubuntu3) saucy; urgency=low
23
24 * debian/patches/git_dont_autostart_under_GNOME.patch (LP: #1189309)
25
26=== renamed file 'debian/patches/git_dont_autostart_under_GNOME.patch' => 'debian/patches/do_not_autostart_under_gnome.patch'
27--- debian/patches/git_dont_autostart_under_GNOME.patch 2013-09-02 14:03:33 +0000
28+++ debian/patches/do_not_autostart_under_gnome.patch 2013-10-04 11:06:18 +0000
29@@ -1,32 +1,22 @@
30-From d6ffe34dc092926fb949449c182e8f27722b6b8b Mon Sep 17 00:00:00 2001
31-From: Dan Winship <danw@gnome.org>
32-Date: Mon, 29 Jul 2013 13:24:15 +0000
33-Subject: Update .desktop files
34-
35-Don't autostart nm-applet in GNOME any more.
36-
37-Update bugzilla info for new components
38-
39-https://bugzilla.gnome.org/show_bug.cgi?id=705074
40----
41-(limited to 'nm-applet.desktop.in')
42-
43-diff --git a/nm-applet.desktop.in b/nm-applet.desktop.in
44-index 996fbac..8f94a88 100644
45+Author: Dmitry Shachnev <mitya57@ubuntu.com>
46+Description: Do not autostart in gnome-shell
47+ This patch makes sure that the applet will not be autostarted
48+ in gnome-shell sessions, but will be autostarted in other
49+ GNOME sessions like the Flashback session. Also it updates
50+ the Bugzilla-Component header following upstream change.
51+Forwarded: yes, https://bugzilla.gnome.org/show_bug.cgi?id=709419
52+Last-Update: 2013-10-04
53+
54 --- a/nm-applet.desktop.in
55 +++ b/nm-applet.desktop.in
56-@@ -6,9 +6,8 @@ Exec=nm-applet
57- Terminal=false
58+@@ -7,8 +7,9 @@
59 Type=Application
60 NoDisplay=true
61--NotShowIn=KDE;
62-+NotShowIn=KDE;GNOME;
63+ NotShowIn=KDE;
64++AutostartCondition=GNOME3 unless-session gnome
65 X-GNOME-Bugzilla-Bugzilla=GNOME
66 X-GNOME-Bugzilla-Product=NetworkManager
67 -X-GNOME-Bugzilla-Component=general
68--X-GNOME-Autostart-enabled=true
69 +X-GNOME-Bugzilla-Component=nm-applet
70+ X-GNOME-Autostart-enabled=true
71 X-GNOME-UsesNotifications=true
72---
73-cgit v0.9.2
74-
75
76=== modified file 'debian/patches/series'
77--- debian/patches/series 2013-09-02 14:03:33 +0000
78+++ debian/patches/series 2013-10-04 11:06:18 +0000
79@@ -16,4 +16,4 @@
80 lp1048516_dont_req_keyring_in_greeter.patch
81 lp1048520_delay_pin_dialog_in_greeter.patch
82 rebuild_menu_after_init.patch
83-git_dont_autostart_under_GNOME.patch
84+do_not_autostart_under_gnome.patch
85
86=== modified file 'nm-applet.desktop.in'
87--- nm-applet.desktop.in 2013-09-02 14:03:33 +0000
88+++ nm-applet.desktop.in 2013-10-04 11:06:18 +0000
89@@ -6,8 +6,10 @@
90 Terminal=false
91 Type=Application
92 NoDisplay=true
93-NotShowIn=KDE;GNOME;
94+NotShowIn=KDE;
95+AutostartCondition=GNOME3 unless-session gnome
96 X-GNOME-Bugzilla-Bugzilla=GNOME
97 X-GNOME-Bugzilla-Product=NetworkManager
98 X-GNOME-Bugzilla-Component=nm-applet
99+X-GNOME-Autostart-enabled=true
100 X-GNOME-UsesNotifications=true

Subscribers

People subscribed via source and target branches