Mir

Code review comment for lp:~mir-team/mir/custom-input-regions-scale-with-surface-size

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I agree, this is not going to be useful.

What I learned very quickly when implementing resizing was that the dominant use case when resizing a surface is that the widgets within that surface mostly don't move (relative to the top left corner). So that's why you see we never scale the surface contents with resizing, but clamp-to-edge instead (stick to the left and top edges, filling the right/bottom with identical pixels till the client supplies a new buffer of the correct size).

As we don't scale our pixels during resizing I don't think it makes any sense to scale the input regions either. Correct behaviour will almost always be: Leave things exactly where they were (relative to top-left) until the client provides information to the contrary.

review: Disapprove

« Back to merge proposal