Merge lp:~mir-team/mir/custom-input-regions-scale-with-surface-size into lp:mir
Status: | Rejected |
---|---|
Rejected by: | Robert Carr |
Proposed branch: | lp:~mir-team/mir/custom-input-regions-scale-with-surface-size |
Merge into: | lp:mir |
Diff against target: |
100 lines (+57/-2) 3 files modified
src/server/scene/basic_surface.cpp (+7/-2) src/server/scene/basic_surface.h (+1/-0) tests/unit-tests/scene/test_basic_surface.cpp (+49/-0) |
To merge this branch: | bzr merge lp:~mir-team/mir/custom-input-regions-scale-with-surface-size |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel van Vugt | Disapprove | ||
Chris Halse Rogers | Needs Information | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email: mp+263168@code.launchpad.net |
Commit message
Scale input rectangles as the surface resizes.
Description of the change
This branch is a preparation for client specified input regions.
To refresh, the requirement is that clients can list regions of their surface which are eligible to receive input and regions which input falls through.
One important question is...what happens when the surface resizes but the client has yet to supply new input rectangles? It seems clear the input rectangles should be scaled to the new surface size...if the client wishes to increase or decrease the resolution of the input mesh a new input shape could be applied.
Recall, we already have input rectangles on the server side, though mostly in an unused format. This branch makes them scale according to the surface size when they were applied.
PASSED: Continuous integration, rev:2702 jenkins. qa.ubuntu. com/job/ mir-ci/ 4219/ jenkins. qa.ubuntu. com/job/ mir-android- vivid-i386- build/3028 jenkins. qa.ubuntu. com/job/ mir-clang- wily-amd64- build/547 jenkins. qa.ubuntu. com/job/ mir-mediumtests -vivid- touch/2976 jenkins. qa.ubuntu. com/job/ mir-wily- amd64-ci/ 375 jenkins. qa.ubuntu. com/job/ mir-wily- amd64-ci/ 375/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ mir-mediumtests -builder- vivid-armhf/ 2976 jenkins. qa.ubuntu. com/job/ mir-mediumtests -builder- vivid-armhf/ 2976/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ mir-mediumtests -runner- mako/5791 s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 21526
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/mir- ci/4219/ rebuild
http://