Code review comment for lp:~milo/linaro-ci-dashboard/correct-chain-build

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

> There are variables that are not part of the Android build service as
> we have now (an example MONKEY_RUNNER):
> Those should be environment variable used at some stage of the build.
> Where: I have no idea.

If you look at it has

"As explained above, you may use other options/variables as supported by Android makefiles (they will be exported to the environment)."

I.e. it's explicitly documented that *arbitrary* variables can be used in , it's just the case that some of variables have well-defined semantics (as documented in, while the rest is just "allowed". So yes, presence of "user_defined_values" is understood, and it's not that easy to map legacy build into new structured build (for that, you should know all strictly defined fields, and parse them out).

« Back to merge proposal