Merge lp:~milo/linaro-ci-dashboard/correct-chain-build into lp:linaro-ci-dashboard
Proposed by
Milo Casagrande
Status: | Merged |
---|---|
Approved by: | Stevan Radaković |
Approved revision: | 50 |
Merged at revision: | 51 |
Proposed branch: | lp:~milo/linaro-ci-dashboard/correct-chain-build |
Merge into: | lp:linaro-ci-dashboard |
Diff against target: |
66 lines (+32/-6) 2 files modified
dashboard/frontend/android_build/models/android_loop.py (+24/-0) dashboard/frontend/models/loop.py (+8/-6) |
To merge this branch: | bzr merge lp:~milo/linaro-ci-dashboard/correct-chain-build |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Stevan Radaković | Approve | ||
Georgy Redkozubov | Pending | ||
Linaro Infrastructure | Pending | ||
Review via email:
|
Description of the change
This branch fixes the problem with chaining into AndroidLoop: when a build was scheduled, the real AndroidLoop was not really created nor built. The part missing was the overriding of the 'preconfigure' method.
I had also to change it into an instance method instead of a classmethod since that caused some problem calling it correctly.
To post a comment you must log in.
This needs some more work here in my opinion. values" ? Do they override the other fields in the loop?
You also have a wrong description here. The build was scheduled for the chained loop, it's just that the results of the textfield loop build were not transferred to the android loop build.
Now the questions remain: shouldn't the dict parameters be mapped into the real android loop fields now? What is "user_defined_