Code review comment for lp:~milo/linaro-ci-dashboard/can-chain-with-method
Revision history for this message
| Milo Casagrande (milo) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
> Ok looks good, but why don't we put it as 'Work in progress' and then review
> it when it's complete?
Oops... you are right, I forgot to un-check the "review" button.
> Or would you like to implement 'provides_for' in a diferrent branch?
No, "provides_for" is basically what we have here in the MP (renamed into "can_chain_with"). It was more for a "are we happy with the name?".
Also, there is not a lot we can do now with the loops we have ATM, apart from defining an empty list. The "start of the chain" will be with the loops in the TextField-form.