Merge lp:~milo/linaro-ci-dashboard/can-chain-with-method into lp:linaro-ci-dashboard

[Milo Casagrande]

Initial proposal for static method to retrieve list of loops that a loop can be chained with.
This is at the moment only the definition in the Loop class, it returns an empty list instead of raising a NotImplementedError.

[Stevan Radaković (stevanr)]

Ok looks good, but why don't we put it as 'Work in progress' and then review it when it's complete?
Or would you like to implement 'provides_for' in a diferrent branch?

[Milo Casagrande (milo)]

> Ok looks good, but why don't we put it as 'Work in progress' and then review
> it when it's complete?

Oops... you are right, I forgot to un-check the "review" button.

> Or would you like to implement 'provides_for' in a diferrent branch?

No, "provides_for" is basically what we have here in the MP (renamed into "can_chain_with"). It was more for a "are we happy with the name?".

Also, there is not a lot we can do now with the loops we have ATM, apart from defining an empty list. The "start of the chain" will be with the loops in the TextField-form.

[Milo Casagrande (milo)]

I relooked at it, and actually this is all we need to implement the 'can_chain_with'.

Loops that inherit from the Loop class will inherit it too, and at the moment, they will not be chainable, since what it will return is an empty list, but we do not have any loop that can be chained with another one (apart the one from the other MP that implements the TextFieldLoop). The class instantiation is in the other MP, but we will probably not need it until the last WI, when we will propagate the loop chain.

[Stevan Radaković (stevanr)]

Ok cool.
Approve +1.

review: Approve

[Данило Шеган (danilo)]

Btw, I find the name here confusing as well: can_chain_with doesn't at all indicate in what direction the chaining will happen. "can_precede_loops" might be better, or anything that clearly identifies the direction as well.

[Данило Шеган (danilo)]

Or perhaps "can_chain_into".

[Milo Casagrande (milo)]

On Fri, Aug 31, 2012 at 10:18 AM, Данило Шеган <email address hidden> wrote:
> Or perhaps "can_chain_into".

I prefer this one, so we maintain the "chain" idea and settle it as
valid terminology for the loops.
Will modify it and then merge.

--
Milo Casagrande
Infrastructure Engineer
Linaro.org <www.linaro.org> │ Open source software for ARM SoCs

[lp:~milo/linaro-ci-dashboard/can-chain-with-method]

33. By Milo Casagrande on 2012-08-31

Renamed method, tweaked doc string.