Code review comment for lp:~mikeycgto/nuvola-player/8tracks-2-0
Revision history for this message
| mikeycgto (mikeycgto) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Just filed the bug (was caused by $j no longer being defined by 8tracks).
Regarding the favorite functionality, I just forgot to re-implement it. I can fix this no problem.
For the updating the NEXT_SONG state, you only have to certain amount of skips on 8tracks (per-mix). There are somethings in the DOM I can use to determine if you can skip the song. I need to just double check a few things and make sure this logic is sound.
Should be able to get these things fixed up and submitted sometime tomorrow. Really love nuvola and will try and help out with service integrations where possible!