Merge lp:~mikeycgto/nuvola-player/8tracks-2-0 into lp:nuvola-player/2.5.x
Proposed by
mikeycgto
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Jiří Janoušek | ||||||||
Approved revision: | no longer in the source branch. | ||||||||
Merged at revision: | 648 | ||||||||
Proposed branch: | lp:~mikeycgto/nuvola-player/8tracks-2-0 | ||||||||
Merge into: | lp:nuvola-player/2.5.x | ||||||||
Diff against target: |
236 lines (+80/-101) 2 files modified
data/nuvolaplayer/services/eighttracks/integration.js (+76/-98) data/nuvolaplayer/services/eighttracks/metadata.conf (+4/-3) |
||||||||
To merge this branch: | bzr merge lp:~mikeycgto/nuvola-player/8tracks-2-0 | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jiří Janoušek | Approve | ||
Review via email: mp+148889@code.launchpad.net |
Description of the change
Updated 8tracks integration to 2.0 of API.
To post a comment you must log in.
Hi. Thanks for fixing and adopting 8tracks service integration. Could you please create a bug report[1] for the issue you have fixed so the fix can be backported to the stable series?
[1] https:/ /bugs.launchpad .net/nuvola- player/ +filebug
=== data/nuvolaplay er/services/ eighttracks/ integration. js
Please add yourself to the list of copyright holders at the beginning of the file.
---
61 - var can_favorite = $("#profile_ link"). length != 0;
You removed and didn't re-implemented functionality to mark a mix as favorite. Is there any reason for this?
---
126 + // TODO implement NEXT_SONG properly updateAction( Nuvola. ACTION_ NEXT_SONG, true);
127 + Nuvola.
Could you elaborate more what do you mean by "implement NEXT_SONG properly"?
=== data/nuvolaplay er/services/ eighttracks/ metadata. conf /about. me/mikeycgto
212 +maintainer_link = https:/
"If you want to have your service integration shipped with Nuvola Player, you must use link to your Launchpad profile." [2]
[2] http:// nuvolaplayer. fenryxo. cz/contribute/ development/ service_ integration. html