Code review comment for lp:~midauth-pisa-devs/hipl/midauth-firewall

On 27.10.2011 00:20, Diego Biurrun wrote:
>> See the referenced thread for details, but essentially we need to
>> mock ipq_get_packet() which is usually provided by linking -lipq.
>
> What I don't get is the reason why we need to mock that function
> in the first place. Probably I am missing something totally
> obvious.

Looking at the patch and judging from my memory, I think it's called by
hipfw_init_context().
On the one hand, much of the firewall code makes heavy direct use of ipq
structures (they're even part of the context structure itself), but now
that you mention it... maybe hipfw_init_context() could still be split
into two functions such that you can just hand it a fake ipq_packet pointer.
What do you think, René?

This would just postpone a more general problem of course, but maybe I
can look into it more thoroughly when the lectures are over.