Code review comment for lp:~michihenning/storage-framework/use-qiodevice

Revision history for this message
James Henstridge (jamesh) wrote :

The Uploader QIODevice is in its open state.

The expected semantics are that you can write to the device and those writes will be buffered, with the bytesWritten signal being used to notify when the write has completed.

While it is possible to signal an error, it seems that this is generally used for hard errors rather than simple "can't complete the write right now" errors. So if we throw away the early writes, we're effectively breaking the contract.

« Back to merge proposal