lp:~michihenning/storage-framework/use-qiodevice

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:storage-framework/devel at revision 90

James Henstridge: Approve on 2016-11-04

unity-api-1-bot: Approve (continuous-integration) on 2016-11-04

Diff: 2011 lines (+568/-498)

16 files modified

include/unity/storage/qt/Downloader.h (+14/-5)
include/unity/storage/qt/Uploader.h (+15/-4)
include/unity/storage/qt/client/internal/remote_client/HandlerBase.h (+1/-0)
include/unity/storage/qt/internal/DownloaderImpl.h (+12/-1)
include/unity/storage/qt/internal/Handler.h (+6/-0)
include/unity/storage/qt/internal/HandlerBase.h (+0/-2)
include/unity/storage/qt/internal/ListJobImplBase.h (+1/-0)
include/unity/storage/qt/internal/UploaderImpl.h (+18/-1)
include/unity/storage/qt/internal/VoidJobImpl.h (+1/-0)
src/qt/Downloader.cpp (+48/-5)
src/qt/Uploader.cpp (+48/-5)
src/qt/internal/DownloaderImpl.cpp (+97/-41)
src/qt/internal/HandlerBase.cpp (+1/-0)
src/qt/internal/UploaderImpl.cpp (+171/-59)
tests/remote-client/MockProvider.cpp (+4/-10)
tests/remote-client/remote-client_test.cpp (+131/-365)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

96. By Michi Henning on 2016-11-04

Renamed finishUpload() and finishDownload() to close().

95. By Michi Henning on 2016-11-04

Review comments from James.

94. By Michi Henning on 2016-11-04

Added code to deal with synchronous wait on uploader.
Not tested yet, because we need to make changes to the mock provider harness for this.

93. By Michi Henning on 2016-11-03

Merged devel.

92. By Michi Henning on 2016-11-02

Got rid of merge conflict file and redundant Q_INVOKABLEs.

91. By Michi Henning on 2016-11-02

Merged dependent branch.

90. By Michi Henning on 2016-11-02

Merged dependent branch.

89. By Michi Henning on 2016-11-01

Suppress warnings from Qt headers.

88. By Michi Henning on 2016-11-01

Added tests for upload/download.

87. By Michi Henning on 2016-11-01

Uploader derives from QIODevice now.