Code review comment for lp:~michael-sheldon/ubuntu-keyboard/improve-predictions

Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Are there any related MPs required for this MP to build/function as expected? Please list.

 * Yes, this mustn't land without https://code.launchpad.net/~michael-sheldon/ubuntu/vivid/presage/fix-apostrophes/+merge/240565 also landing, otherwise presage will crash when encountering apostrophes in the database

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

 * Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

 * Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/ubuntu-keyboard) on device or emulator?

 * Yes

If you changed the UI, was the change specified/approved by design?

 * No change

If you changed UI labels, did you update the pot file?

 * No change

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?

 * No change currently, but we may want to modify this MR and specify a presage version number when that branch has landed.

« Back to merge proposal