Unity Media Scanner Scope

Code review comment for lp:~mhr3/unity-scope-mediascanner/i18n-enablement

  1. i18n-enablement
  2. Merge into trunk
Revision history for this message
James Henstridge (jamesh) wrote :

9 + add_custom_command(OUTPUT ${SCOPE_CONFIG_FILES} COMMAND ${INTLTOOL_MERGE_BIN} -d ${CMAKE_CURRENT_SOURCE_DIR}/../po ${configfile}.in ${configfile} APPEND)

Shouldn't the OUTPUT be ${configfile} here? It will still be picked up by the custom target, if I understand the docs correctly, and would remove the need to use APPEND.

215 + add_custom_command(OUTPUT ${GENERATED_HEADERS} COMMAND ${INTLTOOL_EXTRACT_BIN} --type=gettext/ini --local ${inifile} APPEND)

Same would apply here.

Other than that, it looks good.

« Back to merge proposal