Code review comment for ~mertkirpici/juju-lint:lp/1989575

Revision history for this message
Gabriel Cocenza (gabrielcocenza) wrote :

I liked the idea of having a single requirements-dev.txt at the "principal" folder of the project.

With that said, is there a specific reason why the functional-tests requirements it's not in the same file?

If we have a single requirements-dev.txt it won't be necessary to have the unit and functional requirements.txt and the [testenv] on the .tox file could be responsible to install all dependencies of the project. With that, I guess we can remove deps from [testenv:func], [testenv:func-smoke], [testenv:func-dev] and [testenv:pre-commit].

review: Needs Information

« Back to merge proposal