Code review comment for lp:~mc-return/compiz/compiz.merge-fix957582-use-snprintf-instead-of-sprintf

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

This makes sense as is, although I would recommend using std::string and stringstream where possible in future if individual line performance is not a huge concern (eg, we are not in an inner loop).

I would also recommend fixing all of the SECURE_CODING stuff in one-review where it makes sense to, having a proliferation of reviews for each individual bug is going to be a huge overhead.

review: Approve

« Back to merge proposal