Merge lp:~mc-return/compiz/compiz.merge-fix957582-use-snprintf-instead-of-sprintf into lp:compiz/0.9.9

[MC Return]

Followed a recommendation of Coverity and replaced sprintf () with snprintf () with a buffer size of 128, as the definition says char buf[128].

(LP: #957582)

I guess this sprintf would never overflow, but it does not hurt to silence Coverity and simply replace it either.

Sam, Daniel - you have to decide if you want those Coverity SECURE_CODING recommendations to be followed, then I'll fix the rest of them also, otherwise we should mark those bug reports as invalid or won't fix.

[Sam Spilsbury (smspillaz)]

This makes sense as is, although I would recommend using std::string and stringstream where possible in future if individual line performance is not a huge concern (eg, we are not in an inner loop).

I would also recommend fixing all of the SECURE_CODING stuff in one-review where it makes sense to, having a proliferation of reviews for each individual bug is going to be a huge overhead.

review: Approve

[Stephen M. Webb (bregma)]

OK

review: Approve

=== modified file 'libdecoration/decoration.c'
--- libdecoration/decoration.c	2012-09-10 07:42:57 +0000
+++ libdecoration/decoration.c	2013-01-26 11:28:19 +0000
@@ -2995,7 +2995,7 @@
 
     utf8_string_atom = XInternAtom (xdisplay, "UTF8_STRING", 0);
 
-    sprintf (buf, "_COMPIZ_DM_S%d", screen);
+    snprintf (buf, 128, "_COMPIZ_DM_S%d", screen);
     dm_sn_atom = XInternAtom (xdisplay, buf, 0);
 
     current_dm_sn_owner = XGetSelectionOwner (xdisplay, dm_sn_atom);