Code review comment for lp:~mc-return/compiz/compiz.merge-fix771448-desktop-wall-edge-flipping-broken

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

I figured the screen edge update stuff would be controversial when I added it a few years ago.

The reason why its there is because the screen edge detection windows had an annoying tendency to block input on, eg, panels. That was really, really, annoying.

Instead of removing them, I'd suggest trying to say if you can make it work with that code.

The way it's meant to work as I understand it is that when a window is being dragged, the screen edges will be dynamically re-enabled. Although it was really complicated to get right now I remember, because we had to detect when a grab happened and then figure out whether or not the edges should be enabled because of XDnD grabs being external to our own.

I might branch this off myself tonight and see if I can come up with something a bit better, as it was quite complicated.

review: Abstain

« Back to merge proposal