lp:~mc-return/compiz/compiz.merge-fix771448-desktop-wall-edge-flipping-broken

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:compiz/0.9.10 at revision 3707

PS Jenkins bot (community): Approve (continuous-integration) on 2013-05-15

Sam Spilsbury: Approve on 2013-05-15

Diff: 440 lines (+138/-128)

5 files modified

plugins/wall/src/wall.cpp (+76/-121)
plugins/wall/src/wall.h (+2/-5)
plugins/wall/wall.xml.in (+4/-1)
src/screen.cpp (+7/-1)
tests/manual/plugins/wall.txt (+49/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #771448: desktop wall edge flipping broken	High	Fix Released
Bug #858845: Screen edge actions set in CCSM (scale/expo) don't work (sometimes) - Wall plugin is probably responsible	Medium	Fix Released
Bug #1038677: All Edge bindings are lost on a restart if there is an actual or 'percieved' conflict with edge flip binding	High	Fix Released

Link a bug report

Related blueprints

3680. By MC Return on 2013-05-15

wall: Remove mouse polling edge flip detection code, instead turn edges on
      in the following situations:

    1. Edge flip pointer is on (always on)
    2. Edge flip move is on, and the screen is grabbed (someone is moving
       a window)
    3. Edge flip dnd is on, and a dnd type window is mapped (someone is
       doing a dnd)

Fix a misconstructed boolean condition in removeAction that could cause
actions to be removed twice and as such cause the edge reference count to
go negative.

Note that dnd window detection is a bit imprecise, but I didn't want to resort
to using some exotic workarounds for the dnd edge cases (such as non-EWMH
compliant dnd windows which are still compliant with ICCCM).

Merged branch lp:~smspillaz/compiz/compiz.merge-fix771448-desktop-wall-edge-flipping-broken.wall_edge_flip_logic

3679. By MC Return on 2013-05-15

Merged latest lp:compiz

3678. By MC Return on 2013-05-11

Merged latest lp:compiz

3677. By MC Return on 2013-04-26

Removed void WallScreen::updateScreenEdgeRegions () completely
This is not needed at all, no other plugin needs to re-define the screen
edge regions by itself - just core should do that
The creen edge region updating also confuses the edge flipping functionality
case ConfigureNotify: just breaks out now
Added missing default: case and break (just a style issue)

3676. By MC Return on 2013-04-26

Forgot to commit the most important part

3675. By MC Return on 2013-04-26

Wall:
Fixed broken wall edge flipping
Minor cleanup in bool WallScreen::initiateFlip (...)

3674. By MC Return on 2013-04-26

Grid, code cleanup:

Merged if statements.
Replaced magic number 65535.0f with const float MaxUShortFloat =
std::numeric_limits <unsigned short>::max ();.
Use prefix- instead of postfix-increment.
Removed redundant (float) casts.
Removed redundant brackets.
Added and removed newlines to improve readability.
Minor indentation fixes.

Approved by PS Jenkins bot, Sam Spilsbury.

3673. By MC Return on 2013-04-26

Animation code cleanup:

Use prefix- instead of postfix- in- and decrements.
Removed redundant brackets.
Added and removed newlines where appropriate.
Fixed indentation.

Approved by PS Jenkins bot, Sam Spilsbury.

3672. By MC Return on 2013-04-26

Cube Addon .xml cleanup:

Better plugin description.
Uppercase titles.
Improved tooltips and names.

Approved by PS Jenkins bot, Sam Spilsbury.

3671. By Sam Spilsbury on 2013-04-25

Explicitly check if the smart pointers are null rather than converting
implicitly to bool as boost 1.53 now marks the bool operator as explicit

(LP: #1172601). Fixes: https://bugs.launchpad.net/bugs/1172601.

Approved by PS Jenkins bot, MC Return.