Code review comment for lp:~mc-return/compiz/compiz.merge-fix1169353-screenshot-needs-color-options

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Looks good as it is now.

Don't change the current damageRegion code as it stands, its actually correct in its current form. Where you have a rectangle that varies in size, you should always mark the old rectangle as damaged as well as the new one, because you need to redraw the area underneath where the old rectangle was. This handles the case where the overlay-rectangle is getting smaller.

review: Approve

« Back to merge proposal