lp:~mc-return/compiz/compiz.merge-fix1169353-screenshot-needs-color-options

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:compiz/0.9.10 at revision 3667

PS Jenkins bot (community): Approve (continuous-integration) on 2013-04-24

Sam Spilsbury: Approve on 2013-04-24

MC Return: Needs Resubmitting on 2013-04-24

Diff: 300 lines (+93/-43)

3 files modified

plugins/screenshot/screenshot.xml.in (+30/-5)
plugins/screenshot/src/screenshot.cpp (+62/-38)
plugins/screenshot/src/screenshot.h (+1/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1169353: Screenshot plugin needs possibility to change colors and opacities of the selection rectangle and box	Wishlist	Fix Released
Bug #1172234: Screenshot: Selection box damages the whole screen instead of just the painted region	Medium	Fix Released

Link a bug report

Related blueprints

3662. By MC Return on 2013-04-24

We really never need to damage more than the selected region, removed
call to cScreen->damageScreen (); completely

3661. By MC Return on 2013-04-24

We just want to draw the screenshot selection box if
we are grabbed, the size has changed and the CCSM
option to draw it is enabled

Introduced the new variable bool selectionSizeChanged,
which is true if the size of the selection has changed

Only damage the full screen once, if the grab gets
terminated, during grab just damage the region painted
(the screenshot selection box)

Reduced the cope of the variables x1, y1, x2 and y2
C++ style for comments

3660. By MC Return on 2013-04-24

Replaced magic number 65535.0f with const float MaxUShortFloat =
std::numeric_limits <unsigned short>::max ();

Removed redundant #ifndef USE_GLES compiler option, GLES can cope with
GL_BLEND

3659. By MC Return on 2013-04-23

Better names for the screenshot selection colors
Use prefix- instead of postfix increment
Removed redundant (float) casts

3658. By MC Return on 2013-04-15

*Screenshot, xml:

Better plugin summary
Added option to disable the drawing of the screenshot selection indicator
Added options to change color and opacity of outline and inside of the
rectangle indicator
Other minor improvements

*Screenshot, code:

Do not render anything if indicator is disabled
Indicator colors are now configurable
Minor cleanup in the rendering code
Declaration and assignment of local variables in one line
Indentation fixes

3657. By Sam Spilsbury on 2013-04-15

Install compizconfig backends to the correct libdir

(LP: #1163611). Fixes: https://bugs.launchpad.net/bugs/1163611.

Approved by PS Jenkins bot, MC Return.

3656. By MC Return on 2013-04-15

Screenshot code cleanup:

Used standard bool for mGrab.
Merged a few if condition checks.
Declaration and assignment of local variables in one line.
Removed redundant brackets.
Added and removed newlines to improve readability.
Added a missing break (just a style issue).
Fixed indentation.
C++ style for comments.

Approved by PS Jenkins bot, Sam Spilsbury.

3655. By MC Return on 2013-04-14

Freewins xml:
Fixed False->false and True->true typos.

Credits and thanks for finding cause and fix go to raveit65 !

(LP: #1163606). Fixes: https://bugs.launchpad.net/bugs/1163606.

Approved by PS Jenkins bot, Sam Spilsbury.

3654. By MC Return on 2013-04-13

*Move xml:

Implemented options to configure:

"Snapoff Distance"
"Snapback Semimaximized Windows" and
"Snapback Distance"

Improved a few tooltips.

*Move code:

Replaced SNAP_BACK and SNAP_OFF hardcoded constants and made those
configurable.

Implemented a strategy to snap off horizontally maximized windows by
dragging them along the x axis.

Implemented snapping back of horizontally maximized windows and fixed
the snapping for vertically maximized windows (wrong cursor calculation).

Fixed a few wrong calculations in the if condition checks responsible
for snapping off and back.

Merged if condition checks.

Just compute various local variables if we do not return false.

Removed redundant brackets, fixed indentation and improved readability.

(LP: #1165198, LP: #1167933). Fixes: https://bugs.launchpad.net/bugs/1165198, https://bugs.launchpad.net/bugs/1167208, https://bugs.launchpad.net/bugs/1167933.

Approved by PS Jenkins bot, Sam Spilsbury.

3653. By Hu Kang <email address hidden> on 2013-04-10

workarounds.cpp: Fix typo in call to XShapeSelectInput.

(LP: #1167284). Fixes: https://bugs.launchpad.net/bugs/1167284.

Approved by PS Jenkins bot, Sam Spilsbury.