Code review comment for lp:~mc-return/compiz/compiz.merge-fix1169353-screenshot-needs-color-options

> Please do it separately. If there are comments I have about the damage
> handling fix they'll also hold up this merge request too.
>
It is all already done and all fixed, I will explain in detail what I changed
to fix the damage handling, it was just a minor issue:

267 -
268 - cScreen->damageScreen ();
269 }
270 +
271 + cScreen->damageScreen ();

It was damaging the whole screen during a size change instead of just damaging
the screen once the operation was finished (the mouse button is released).

The other thing I fixed in r3661 was a permanent redraw problem, because the
overlay got overdrawn when there was no movement. This is now fixed also.
This was the blending problem I discovered and have written about earlier here:

> > I still have a minor blending problem to fix,

This was fixed by introducing the new variable bool selectionSizeChanged,
which is true if the size of the selection has changed, please see r3661
for details on this:

http://bazaar.launchpad.net/~mc-return/compiz/compiz.merge-fix1169353-screenshot-needs-color-options/revision/3661

>
> You need to set the read buffer to GL_BACK I think. I'm a bit hesitant
> about giving that advice though until we have a proper abstraction
> for tracking framebuffer attachment points inside of compiz - querying
> OpenGL is sloowwwww.
>

I will do some more experiments and try to fix this last issue in another MP.
Thanks a lot for the tip. :)