Code review comment for lp:~mc-return/compiz/compiz.merge-fix1169353-screenshot-needs-color-options

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

The ifndefs are not necessary for enabling the blend state. Its a side effect of when Travis had turned on blend full-time, but we decided to revert that change because while it was certainly convenient, it had some performance implications and there are also some situations where blending is not desired.

short unsigned int basically going to be 16 bits on every architecture we care about. If we start caring about really exotic hardware then maybe that will need to change, but I don't imagine its the case now.

65535 is a lot easier to typo if you have it everywhere.

« Back to merge proposal