Code review comment for lp:~mc-return/compiz/compiz.merge-fix1033877-fix-uninitialized-class-member-variables-in-constructors

Revision history for this message
MC Return (mc-return) wrote :

Thanks a lot for the review and approval. I was not sure if 0 is the best initialization value everywhere, but I am currently running all those changes here and all seems good. :)

Regarding the auto zero-initialization: I do not know. Maybe it also depends on the compiler. Maybe it is just a question of style. But I thought it would not hurt to eliminate the complaints cppcheck has. ;)
Also almost all of such cases do get initialized manually already, so I thought it would be best to do it for all of them.
(some still remain - see description note above)

« Back to merge proposal