Merge lp:~mc-return/compiz/compiz.merge-fix1033877-fix-uninitialized-class-member-variables-in-constructors into lp:compiz/0.9.9

[MC Return]

Initialized all class member variables in their respective constructors.
Used false for bools, 0.0f for floats, 0 for ints and 0 for object pointers like *autoProgram and *screen.

Initialized all class member variables in their respective constructors.
Used false for bools, 0.0f for floats, 0 for ints and 0 for object pointers like *autoProgram and *screen.

Should I have used NULL to initialize the individual object pointers ?

Note: I did not fix the same issue for currently disabled plug-ins like trip or non-working plug-ins like firepaint or showmouse. So these tasks still remain open.

[lp:~mc-return/compiz/compiz.merge-fix1033877-fix-uninitialized-class-member-variables-in-constructors]

3455. By MC Return on 2012-11-04

Also initialize the member variables int previewWidth, previewHeight, previewBorder and xCount in the StaticSwitchScreen::StaticSwitchScreen (CompScreen *screen) constructor

3456. By MC Return on 2012-11-04

Also initialize the member variable int refCount in the Decoration::Decoration (...) constructor

[Sam Spilsbury (smspillaz)]

This is good, although I remember someone once told me that they get zero-initialized automatically. I could be wrong though.

review: Approve

[MC Return (mc-return)]

Thanks a lot for the review and approval. I was not sure if 0 is the best initialization value everywhere, but I am currently running all those changes here and all seems good. :)

Regarding the auto zero-initialization: I do not know. Maybe it also depends on the compiler. Maybe it is just a question of style. But I thought it would not hurt to eliminate the complaints cppcheck has. ;)
Also almost all of such cases do get initialized manually already, so I thought it would be best to do it for all of them.
(some still remain - see description note above)

[Stephen M. Webb (bregma)]

For the record: member variables do not get initialized automatically, they remain uninitialized (undefined values). Zero for pointer initialization instead of NULL is OK since NULL is required to be a #define for 0 in C++ but the value nullptr is better if the code is compiled using the current standard.

This change is good.

review: Approve

=== modified file 'plugins/animation/src/glide.cpp'
--- plugins/animation/src/glide.cpp	2009-07-15 16:05:10 +0000
+++ plugins/animation/src/glide.cpp	2012-11-04 18:08:20 +0000
@@ -45,7 +45,8 @@
 		      const CompRect &icon) :
     Animation::Animation (w, curWindowEvent, duration, info, icon),
     TransformAnim::TransformAnim (w, curWindowEvent, duration, info, icon),
-    ZoomAnim::ZoomAnim (w, curWindowEvent, duration, info, icon)
+    ZoomAnim::ZoomAnim (w, curWindowEvent, duration, info, icon),
+    glideModRotAngle (0.0f)
 {
 }
 

=== modified file 'plugins/animation/src/magiclamp.cpp'
--- plugins/animation/src/magiclamp.cpp	2012-05-18 06:52:20 +0000
+++ plugins/animation/src/magiclamp.cpp	2012-11-04 18:08:20 +0000
@@ -58,7 +58,9 @@
 			      const AnimEffect info,
 			      const CompRect &icon) :
     Animation::Animation (w, curWindowEvent, duration, info, icon),
-    GridAnim::GridAnim (w, curWindowEvent, duration, info, icon)
+    GridAnim::GridAnim (w, curWindowEvent, duration, info, icon),
+    mTopLeftCornerObject (0),
+    mBottomLeftCornerObject (0)
 {
     CompRect outRect (mAWindow->savedRectsValid () ?
 		      mAWindow->savedOutRect () :

=== modified file 'plugins/composite/src/screen.cpp'
--- plugins/composite/src/screen.cpp	2012-10-16 05:11:10 +0000
+++ plugins/composite/src/screen.cpp	2012-11-04 18:08:20 +0000
@@ -279,6 +279,20 @@
 
 PrivateCompositeScreen::PrivateCompositeScreen (CompositeScreen *cs) :
     cScreen (cs),
+    compositeEvent (0),
+    compositeError (0),
+    compositeOpcode (0),
+    damageEvent (0),
+    damageError (0),
+    fixesEvent (0),
+    fixesError (0),
+    fixesVersion (0),
+    shapeExtension (false),
+    shapeEvent (0),
+    shapeError (0),
+    randrExtension (false),
+    randrEvent (0),
+    randrError (0),
     damageMask (COMPOSITE_SCREEN_DAMAGE_ALL_MASK),
     overlay (None),
     output (None),

=== modified file 'plugins/decor/src/decor.cpp'
--- plugins/decor/src/decor.cpp	2012-09-17 15:25:00 +0000
+++ plugins/decor/src/decor.cpp	2012-11-04 18:08:20 +0000
@@ -597,6 +597,7 @@
 			unsigned int nQuad,
 			Window       owner,
 			DecorPixmapRequestorInterface *requestor) :
+    refCount (0),
     texture (DecorScreen::get (screen)->getTexture (pixmap)),
     border (border.left, border.right, border.top, border.bottom),
     input (input.left, input.right, input.top, input.bottom),

=== modified file 'plugins/ezoom/src/ezoom.cpp'
--- plugins/ezoom/src/ezoom.cpp	2012-10-15 12:51:26 +0000
+++ plugins/ezoom/src/ezoom.cpp	2012-11-04 18:08:20 +0000
@@ -211,6 +211,7 @@
 }
 
 EZoomScreen::ZoomArea::ZoomArea () :
+    output (0),
     viewport (~0),
     currentZoom (1.0f),
     newZoom (1.0f),
@@ -1874,7 +1875,12 @@
 /* TODO: Use this ctor carefully */
 
 EZoomScreen::CursorTexture::CursorTexture () :
-    isSet (false)
+    isSet (false),
+    screen (0),
+    width (0),
+    height (0),
+    hotX (0),
+    hotY (0)
 {
 }
 

=== modified file 'plugins/opengl/src/screen.cpp'
--- plugins/opengl/src/screen.cpp	2012-10-16 04:49:19 +0000
+++ plugins/opengl/src/screen.cpp	2012-11-04 18:08:20 +0000
@@ -1147,6 +1147,7 @@
     #endif
     scratchFbo (NULL),
     outputRegion (),
+    refreshSubBuffer (false),
     lastMask (0),
     bindPixmap (),
     hasCompositing (false),

=== modified file 'plugins/opengl/src/vertexbuffer.cpp'
--- plugins/opengl/src/vertexbuffer.cpp	2012-09-05 23:54:21 +0000
+++ plugins/opengl/src/vertexbuffer.cpp	2012-11-04 18:08:20 +0000
@@ -387,7 +387,8 @@
     nTextures (0),
     vertexOffset (0),
     maxVertices (-1),
-    program (NULL)
+    program (NULL),
+    autoProgram (0)
 {
     if (!GL::genBuffers)
 	return;

=== modified file 'plugins/staticswitcher/src/staticswitcher.cpp'
--- plugins/staticswitcher/src/staticswitcher.cpp	2012-09-07 23:56:21 +0000
+++ plugins/staticswitcher/src/staticswitcher.cpp	2012-11-04 18:08:20 +0000
@@ -1345,6 +1345,10 @@
     BaseSwitchScreen (screen),
     PluginClassHandler<StaticSwitchScreen,CompScreen> (screen),
     clientLeader (None),
+    previewWidth (0),
+    previewHeight (0),
+    previewBorder (0),
+    xCount (0),
     switching (false),
     mVelocity (0.0),
     pos (0),