Merge lp:~mbp/launchpad/888353-microformats into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Martin Pool |
Approved revision: | no longer in the source branch. |
Merged at revision: | 14377 |
Proposed branch: | lp:~mbp/launchpad/888353-microformats |
Merge into: | lp:launchpad |
Diff against target: |
173 lines (+50/-12) 7 files modified
lib/lp/app/doc/hierarchical-menu.txt (+1/-1) lib/lp/app/templates/base-layout.pt (+2/-0) lib/lp/app/templates/launchpad-hierarchy.pt (+1/-0) lib/lp/bugs/browser/tests/test_bugcomment.py (+29/-0) lib/lp/bugs/stories/bugs/xx-bug-comments-truncated.txt (+3/-3) lib/lp/bugs/templates/bugcomment-box.pt (+13/-7) lib/lp/bugs/templates/bugtask-index.pt (+1/-1) |
To merge this branch: | bzr merge lp:~mbp/launchpad/888353-microformats |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Raphaël Badin (community) | Approve | ||
Review via email: mp+82767@code.launchpad.net |
Commit message
[r=rvb][bug=888353] add schema.org microformats for bugs and breadcrumbs
Description of the change
This adds a small amount of schemas.org to the main bug page and to the generic breadcrumbs, with a goal of getting search engines to give better summaries snippets of bug pages that turn up in search results.
To see whether it actually does work or not we'll need to deploy this and wait for it to be indexed. We could do a lot more but this is an experiment to see if it has a noticeable effect.
There are not any (intentional) changes is normal page content or behaviour.
You can see Google's test parser on it at <http://
Hi Martin, this looks like a very good idea but I've got a few remarks. I'm no microformat expert so please bear with me ;).
= Real questions/remarks =
[0]
8 + itemscope itemtype="http:// schema. org/WebPage"
You only include the breadcrumbs here, don't you think it would be useful (for the test to be complete), to also include a name (http:// schema. org/Thing) and a URL (http:// schema. org/Thing) [and maybe a description (http:// schema. org/Thing)]? Obviously the parser can take the url as an identifier but maybe it's better if we explicitly provide one.
[1]
38 + itemprop= "commentTime"
I'm not sure "on XXX" is correctly parsed as a date, and I'm pretty sure "a moment ago" won't be. Maybe it would be worth to add the date properly formatted in the tag with an attribute such as """ datetime= "2007-10- 20" """.
[2]
I cannot help but notice that there is no test for this. I understand this is a test so it's probably ok… Maybe you could include an empty (or almost empty) test for this with a reference to this bug just so that we don't forget to add tests should we develop this further.
= Details =
[0]
37 <span tal:attributes= "title comment/ datecreated/ fmt:datetime" "commentTime" "comment/ datecreated/ fmt:displaydate ">
38 + itemprop=
39 tal:content=
Weird formatting here.
[1]
45 <td class=" bug-comment- index"> "href comment/fmt:url" "string: #${comment/index}" /> "href comment/fmt:url" "string: #${comment/index}" />
46 - <a tal:attributes=
47 - tal:content=
48 + <a itemprop="url"
49 + tal:attributes=
50 + tal:content=
And here.