Merge lp:~mbp/bzr/integration-old into lp:~bzr/bzr/trunk-old
Proposed by
Martin Pool
Status: | Merged | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Approved by: | John A Meinel | ||||||||||||
Approved revision: | no longer in the source branch. | ||||||||||||
Merged at revision: | not available | ||||||||||||
Proposed branch: | lp:~mbp/bzr/integration-old | ||||||||||||
Merge into: | lp:~bzr/bzr/trunk-old | ||||||||||||
Diff against target: | 257 lines | ||||||||||||
To merge this branch: | bzr merge lp:~mbp/bzr/integration-old | ||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
John A Meinel | Approve | ||
Review via email: mp+9558@code.launchpad.net |
To post a comment you must log in.
In the distant past we did a lot of file IO indirectly through LockableFiles. We now use the transport directly. This deletes some deprecated methods that forwarded to the transport, and their tests.
CountedLock. get_physical_ lock status merely forwards so doesn't urgently need a test.
In passing I noticed this strange behaviour that get_branch_ transport may or may not actually create a directory depending on whether you specify the format, thus the comment.