Code review comment for lp:~mbp/bzr/integration-old

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> Martin Pool has proposed merging lp:~mbp/bzr/integration into lp:bzr.
>
> Requested reviews:
> bzr-core (bzr-core)
>
> In the distant past we did a lot of file IO indirectly through LockableFiles. We now use the transport directly. This deletes some deprecated methods that forwarded to the transport, and their tests.
>
> CountedLock.get_physical_lock status merely forwards so doesn't urgently need a test.
>
> In passing I noticed this strange behaviour that get_branch_transport may or may not actually create a directory depending on whether you specify the format, thus the comment.
>

 review: approve
 merge: approve

Though I'm a bit surprised you consider it difficult to test the
get_physical_lock_status.

Also, what is calling this function? As I see you added something new,
but did not add any new callers.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkp26FEACgkQJdeBCYSNAANdtACeJt0Tkv0erqSnI6fQaA8G5IO6
l2cAoNM6YvsPiiejgSeS+U3nnef+SGEH
=88nM
-----END PGP SIGNATURE-----