Code review comment for lp:~matzipan/egtk/egtk

Revision history for this message
Danielle Foré (danrabbit) wrote :

in .fingerprint:
* instead of using a solid border color, you should probably use a box shadow here (semi-transparent black) as we do with window frames. This ensures that you won't get a blurry border effect on the element.

in .fingerprint-label:
* We don't use rgba typically. Please use alpha instead
* Instead of defining a new text style, it would be preferable to use one of the header classes from gtk-widgets.css. Specifically, the "h3" class is an 11px style.

review: Needs Fixing

« Back to merge proposal