Merge lp:~matzipan/egtk/egtk into lp:~elementary-design/egtk/trunk

[Zisu Andrei]

Linked to this code https://code.launchpad.net/~matzipan/pantheon-greeter/fprintd-fixes/+merge/287397

[Danielle Foré (danrabbit)]

in .fingerprint:
* instead of using a solid border color, you should probably use a box shadow here (semi-transparent black) as we do with window frames. This ensures that you won't get a blurry border effect on the element.

in .fingerprint-label:
* We don't use rgba typically. Please use alpha instead
* Instead of defining a new text style, it would be preferable to use one of the header classes from gtk-widgets.css. Specifically, the "h3" class is an 11px style.

review: Needs Fixing

[lp:~matzipan/egtk/egtk]

642. By Zisu Andrei on 2016-03-07

Review fixes

[Zisu Andrei (matzipan)]

> * instead of using a solid border color, you should probably use a box shadow here (semi-transparent black) as we do with window frames. This ensures that you won't get a blurry border effect on the element.

I just copied the CSS from the avatar. I have removed it now.

> * Instead of defining a new text style, it would be preferable to use one of the header classes from gtk-widgets.css. Specifically, the "h3" class is an 11px style.

Done.

review: Needs Resubmitting (fixed)

[Danielle Foré (danrabbit)]

Superseded by https://code.launchpad.net/~elementary-pantheon/pantheon-greeter/fingerprint-rewrite

review: Disapprove

Unmerged revisions

642. By Zisu Andrei on 2016-03-07

Review fixes

641. By Zisu Andrei on 2016-02-27

Add style for greeter fingerprint prompt

=== modified file 'gtk-3.0/apps.css'
--- gtk-3.0/apps.css	2016-03-07 04:02:53 +0000
+++ gtk-3.0/apps.css	2016-03-07 12:04:16 +0000
@@ -184,6 +184,31 @@
                 0 2px 6px alpha (#000, 0.10);
 }
 
+PantheonGreeter .fingerprint {
+  background-image: linear-gradient(to bottom,  
+                                shade (#666, 1.30),
+                                #666
+                                );
+    border-radius: 50%;
+    box-shadow: inset 0 0 0 1px alpha (#999, 0.05),
+            inset 0 1px 0 0 alpha (#999, 0.45),
+            inset 0 -1px 0 0 alpha (#999, 0.15),
+            0 1px 2px alpha (#000, 0.15),
+            0 2px 6px alpha (#000, 0.10);
+}
+
+PantheonGreeter .fingerprint-label {
+    text-shadow: 0 0 3px alpha (#000, 0.4);
+}
+
+PantheonGreeter .fingerprint-label.info {
+    color: alpha (#fff,0.8);
+}
+
+PantheonGreeter .fingerprint-label.error {
+    color: lighter(@error_color);
+}
+
 PantheonGreeter .entry,
 PantheonGreeter .entry:focus {
     border-radius: 3.5px;